Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use https_proxy from env variables #50

Merged
merged 2 commits into from
May 23, 2022
Merged

use https_proxy from env variables #50

merged 2 commits into from
May 23, 2022

Conversation

j-raccoon
Copy link
Contributor

We use xwin for cross-compilation on a CI/CD-runner behind our corporate proxy.

This PR enables xwin to download files behind a proxy by reading https_proxy environment variable and setting up proxy config when building ureq::Agent in http_client()

@j-raccoon j-raccoon requested a review from Jake-Shadle as a code owner May 20, 2022 11:28
Jake-Shadle
Jake-Shadle requested changes May 20, 2022
View reviewed changes
src/ctx.rs Show resolved Hide resolved
@Jake-Shadle Jake-Shadle self-requested a review May 23, 2022 07:14
Jake-Shadle
Jake-Shadle approved these changes May 23, 2022
View reviewed changes
Copy link
Owner

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Jake-Shadle Jake-Shadle merged commit a9d40c9 into Jake-Shadle:main May 23, 2022
@j-raccoon j-raccoon deleted the use-https-proxy branch May 23, 2022 07:19
@Jake-Shadle Jake-Shadle mentioned this pull request Nov 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jake-Shadle Jake-Shadle Jake-Shadle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j-raccoon @Jake-Shadle