Change where get max and min get called #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will mean get_max will only call once at start. |
|
Wait, cpus max and min can change independently |
|
@Camerooooon @Shuzhengz Do we think that min and max cpu speed will change when this is running? |
|
min will be 0 (cant have negative hz), and max will be the max boost clock for the specific cpu (unless they somehow manages to overclock their laptop cpu, in that case you need msr to read it) |
|
Cool, thanks |
|
I remember we were talking about having a setting to undo this change in case people had hot-swappable cpus but maybe it isn't something we need to super. Should we merge this? It just reduces the call of get_max and get_min from every tick to just once at the start |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #99