Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Animation Postition #173

Merged
merged 9 commits into from
Feb 3, 2022
Merged

Fix Animation Postition #173

merged 9 commits into from
Feb 3, 2022

Conversation

Shuzhengz
Copy link
Collaborator

Move it down one line because oops

Move it down one line
@Shuzhengz Shuzhengz marked this pull request as draft January 31, 2022 19:12
@Shuzhengz
Copy link
Collaborator Author

wait we need to check if the window is in wide or floating

@Shuzhengz Shuzhengz changed the title Update Animation Postition Fix Animation Postition Jan 31, 2022
@JakeRoggenbuck
Copy link
Owner

We also have to check the size of the windows (width) because the first line can wrap and move it

@JakeRoggenbuck
Copy link
Owner

We may also want future stuff to be before the turbo so we need to make the location variable

@Shuzhengz
Copy link
Collaborator Author

yee

@Camerooooon
Copy link
Collaborator

Camerooooon commented Feb 1, 2022

When I run this code I get the animation looks like

Battery: 84%
  Turbo: yes
◷

Whilst normally it looks like:

Battery: 84%
◷ Turbo: yes

The second one is what I believe to be the intended behaviors.
So what is the purpose of this PR?

The issue pertains to the size of the window. Sometimes, if the text wraps it will effect the position of the animation.

@Shuzhengz
Copy link
Collaborator Author

thats why its still a draft pr lol
im still working on fixing it

@Shuzhengz Shuzhengz marked this pull request as ready for review February 3, 2022 06:52
@Shuzhengz
Copy link
Collaborator Author

Shuzhengz commented Feb 3, 2022

I also added a function to keep track of terminal size

@JakeRoggenbuck
Copy link
Owner

Looks good! Will test tomorrow morning on laptop!

@JakeRoggenbuck JakeRoggenbuck merged commit 70dbf32 into main Feb 3, 2022
@Shuzhengz Shuzhengz deleted the anim-pos-update branch February 15, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants