-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add norms #183
Add norms #183
Conversation
I just want to do this before the project gains more traction, because we might see others contributing soon |
and thats really exciting |
|
||
## Pull Requests | ||
- Pull requests must be tested but with `cargo test` and ran on local machine (laptop with battery) | ||
- Pull requests that change core functionality must have a review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change that to all PRs must have at least 1 review unless it's by jake cuz jakes cool
If you would like to help complete a task, comment in the issue and we may assign it to you! | ||
|
||
## Pull Requests | ||
- Pull requests must be tested but with `cargo test` and ran on local machine (laptop with battery) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add that WIP PRs should be drafts
## Releases | ||
- Before a release, we test on several computers making sure they all function, and all function the same | ||
- We add a git tag to the branch and push it | ||
- Then we draft and publish the release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe say roughly how long will the program be updated and new version released (ie every few months, every few weeks, every minute)
## Releases | ||
- Before a release, we test on several computers making sure they all function, and all function the same | ||
- We add a git tag to the branch and push it | ||
- Then we draft and publish the release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also maybe we should start doing pre releases when we get enough attention to update on progress
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, we should definitely do that, then we can test more and let people test before we publish
|
||
## Projects tab | ||
- The [projects tab](https://github.com/JakeRoggenbuck/auto-clock-speed/projects/1) is something we use extensively to organize when things get done | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an idea, but maybe we should start thinking of a wiki to put all the documentations into?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yee
fixed stuff, thanks for the feedback! |
yee! |
No description provided.