Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the most basic show config #208

Merged
merged 4 commits into from
Feb 12, 2022
Merged

Add the most basic show config #208

merged 4 commits into from
Feb 12, 2022

Conversation

JakeRoggenbuck
Copy link
Owner

@JakeRoggenbuck JakeRoggenbuck commented Feb 6, 2022 •
edited
Loading

fixes #207

@JakeRoggenbuck
Copy link
Owner Author

Needs test

@Shuzhengz
Copy link
Collaborator

wait which command does --print-config go with?

@JakeRoggenbuck
Copy link
Owner Author

I just changed it to a sub command of showconfig

acs showconfig

@Shuzhengz
Copy link
Collaborator

ooo ok

Shuzhengz
Shuzhengz requested changes Feb 6, 2022
View reviewed changes
Copy link
Collaborator

@Shuzhengz Shuzhengz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, but if it's using default config then its just going to error out instead of showing the default config

@JakeRoggenbuck
Copy link
Owner Author

Hm, yea. I can fix that

@Shuzhengz
Copy link
Collaborator

also the dependency package count went from 70 to 186 in this pr, need to test the peformance effects

@JakeRoggenbuck
Make showconfig output the config in use
9cfff40 
- This means not just the config file but the one that will be used by
  default if one is not specified as well
@Shuzhengz Shuzhengz added the enhancement New ideas or features to add label Feb 6, 2022
@JakeRoggenbuck
Copy link
Owner Author

Yea, we can remove bat, because that is pretty intense

@JakeRoggenbuck
Copy link
Owner Author

Should be good to go now

Camerooooon
Camerooooon approved these changes Feb 12, 2022
View reviewed changes
Copy link
Collaborator

@Camerooooon Camerooooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works :)

@JakeRoggenbuck
Copy link
Owner Author

Thanks!

@JakeRoggenbuck JakeRoggenbuck merged commit d300b11 into main Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camerooooon Camerooooon Camerooooon approved these changes

@Shuzhengz Shuzhengz Shuzhengz approved these changes

Assignees
No one assigned
Labels
enhancement New ideas or features to add
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Config viewer
3 participants
@JakeRoggenbuck @Shuzhengz @Camerooooon