-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add powersave on overheat rules #221
Conversation
|
Ok, the logic of this needs to be tested. We need to make sure that plugging in the laptop won't override the temperature rule. I don't have my charge so I can't test this right now. |
I can test in a bit |
Only one thing I would change, commit and should_graph were moved to settings.rs, so they can be removed from daemon_init and struct Daemon, but other than that, looks good! |
I'm also making temp threshold configurable. |
Smart getting get_highest temp, because sometimes one core might be like wayyyy higher and could get damaged without the system average being too hot. good job! |
Yees!! |
oop, you got it! |
Awesome, looks great!! |
I can test tomorrow morning |
fixes #122 |
The logic looks solid. Great implementation. The only real way to test is to put a heater up to the laptop while opening a million tabs. I will try setting the threshold low, then put my laptop in the freezer, then move it into a space heater while building kernel from source. Wish me luck. |
@Camerooooon good to merge? |
Plugging it in after temp is overheating is going to cause problems. We don't want the governor to switch back to performance when you plug the laptop in. |
|
Good idea! That's a clean way to solve this issue. How about we merge this as is and make that a later PR? |
Sure, that would be good. I can make the state.rs and stuff, and then we could work together on adding state everywhere |
Right now I'm unsure if this logic is correct