Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely open config #231

Merged
merged 3 commits into from
Feb 15, 2022
Merged

Safely open config #231

merged 3 commits into from
Feb 15, 2022

Conversation

JakeRoggenbuck
Copy link
Owner

fixes #227

@JakeRoggenbuck
Copy link
Owner Author

tested

src/config.rs Outdated

impl SafeFillConfig for SafeConfig {
fn safe_fill_config(&mut self) -> Config {
// This function makes sure the config contains ever value from Config,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

every?

Copy link
Collaborator

@Shuzhengz Shuzhengz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested (but not under sudo yet), lgtm

@JakeRoggenbuck
Copy link
Owner Author

Yee, i can double check for sudo, thanks!

@JakeRoggenbuck
Copy link
Owner Author

Works with sudo

@JakeRoggenbuck JakeRoggenbuck merged commit 4831c3c into main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for some values to not be defined in config
3 participants