Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ignore power and lid #291

Merged
merged 2 commits into from
May 29, 2022
Merged

Add ignore power and lid #291

merged 2 commits into from
May 29, 2022

Conversation

JakeRoggenbuck
Copy link
Owner

@JakeRoggenbuck JakeRoggenbuck commented May 28, 2022

fixes #253

Copy link
Collaborator

@Camerooooon Camerooooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works properly, maybe we should do a simpler implementation for the end user. Perhaps we could have a enabled_rules value on the config which contains a list of the currently active rules, (ex battery, lid, cpu_usage etc).

Copy link
Collaborator

@Shuzhengz Shuzhengz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works on my laptop

@JakeRoggenbuck
Copy link
Owner Author

JakeRoggenbuck commented May 29, 2022

It works properly, maybe we should do a simpler implementation for the end user. Perhaps we could have a enabled_rules value on the config which contains a list of the currently active rules, (ex battery, lid, cpu_usage etc).

I like this idea, yea

@JakeRoggenbuck
Copy link
Owner Author

I'll make a new issue for two things,

  • A list active rules command
  • A enable/disable rules in config.

@JakeRoggenbuck
Copy link
Owner Author

Yea, and also, that list of rules in the config could represent an actual list of function pointers that get called each cycle.

@JakeRoggenbuck
Copy link
Owner Author

We could probably do both the ignore_power + ignore_lid, and the select/deselect specific rules to allow easy toggle of rules or manual and controlled specific rules. This would also probably be really helpful for debugging.

@JakeRoggenbuck
Copy link
Owner Author

I'll probably merge this because it's a start, but I'll make an issue to add the extended version because it's a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to ignore power
3 participants