-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignore power and lid #291
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works properly, maybe we should do a simpler implementation for the end user. Perhaps we could have a enabled_rules
value on the config which contains a list of the currently active rules, (ex battery, lid, cpu_usage etc).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works on my laptop
I like this idea, yea |
I'll make a new issue for two things,
|
Yea, and also, that list of rules in the config could represent an actual list of function pointers that get called each cycle. |
We could probably do both the ignore_power + ignore_lid, and the select/deselect specific rules to allow easy toggle of rules or manual and controlled specific rules. This would also probably be really helpful for debugging. |
I'll probably merge this because it's a start, but I'll make an issue to add the extended version because it's a good idea. |
fixes #253