Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule for cpu usage #292

Merged
merged 7 commits into from
May 29, 2022

Conversation

Camerooooon
Copy link
Collaborator

@Camerooooon Camerooooon commented May 29, 2022

Implements #271

@Camerooooon
Copy link
Collaborator Author

Camerooooon commented May 29, 2022

So this PR implements the cpu usage rule however it doesn't actually set the governor, this is because I don't want to mess around with the weird overlapping rules when it's going to be refactored in #298. I think we should merge this now (since it doesn't break anything) then I can avoid merge issues in the future. @JakeRoggenbuck does that make sense?

Copy link
Owner

@JakeRoggenbuck JakeRoggenbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@JakeRoggenbuck JakeRoggenbuck merged commit f114bf9 into JakeRoggenbuck:main May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants