-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New graphing modes for --graph #301
Merged
JakeRoggenbuck
merged 12 commits into
JakeRoggenbuck:main
from
Camerooooon:cpu-usage-graph
Jun 5, 2022
Merged
New graphing modes for --graph #301
JakeRoggenbuck
merged 12 commits into
JakeRoggenbuck:main
from
Camerooooon:cpu-usage-graph
Jun 5, 2022
+110
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a massive PR please make sure to test rigorously and leave comments! |
Camerooooon
requested review from
JakeRoggenbuck and
Shuzhengz
and removed request for
JakeRoggenbuck
June 1, 2022 02:34
Closes #285 |
Closed
Great job, this looks really good, I think I have one or two things of feedback. |
Everything graphing works as intended and a very good solution! |
Laptop tested |
Shuzhengz
approved these changes
Jun 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ayy
JakeRoggenbuck
approved these changes
Jun 5, 2022
Shuzhengz
approved these changes
Jun 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added multiple new modes for different types of graphing. This includes graphing the CPU usage, CPU temperature, and CPU frequency. I also changed the way we parse the --graph command so that the user can provide a graph type.