Thermal Zones #347
Thermal Zones #347
Conversation
| @@ -290,6 +290,28 @@ pub fn list_cpu_governors() -> Vec<String> { | |||
| list_cpus().into_iter().map(|x| x.gov).collect() | |||
| } | |||
|
|
|||
| pub fn read_int(path: &str) -> Result<i32, Error> { | |||
There was a problem hiding this comment.
Yeah I noticed that they would be duplicate with the thermal zone reader. We also need to refactor the cpus code it's a little wacky I feel like. That's an issue for another time.
| } | ||
| } | ||
|
|
||
| pub fn read_thermal_zones() -> Vec<ThermalZone> { |
| pub fn read_thermal_zones() -> Vec<ThermalZone> { | ||
| let mut zones = Vec::<ThermalZone>::new(); | ||
|
|
||
| for a in read_dir(THERMAL_ZONE_DIR).expect("Could not read thermal directory") { |
There was a problem hiding this comment.
prob wanna check the type first, since most thermal zones are just constants (there is no thermal zones for each individual cores, instead it is shown as one x86_pkg_temp)
There was a problem hiding this comment.
also fun fact, there are 19 thermal zones on my hexacore laptop, 11 thermal zones on my octacore laptop, and 2 on my dual-core laptop
There was a problem hiding this comment.
prob wanna check the type first, since most thermal zones are just constants (there is no thermal zones for each individual cores, instead it is shown as one
x86_pkg_temp)
I'm planning on converting type to an enum with a catch all type "other" for all undocumented thermal zones. That way we can filter out all virtual thermal zones
There was a problem hiding this comment.
I'm planning on converting type to an enum with a catch all type "other" for all undocumented thermal zones. That way we can filter out all virtual thermal zones
This doesn't seem to be necessary.
| @@ -0,0 +1,40 @@ | |||
| use super::Error; | |||
There was a problem hiding this comment.
we could prob also add fan speed and cooling here later since they are in the same directory
There was a problem hiding this comment.
The cooling devices didn't show fan speed on my laptop.
There was a problem hiding this comment.
hmmm, maybe its device or manufacture specific then
There was a problem hiding this comment.
hmmm, maybe its device or manufacture specific then
Could be bios security. I'll check when I get a chance.
There was a problem hiding this comment.
So I couldn't find fan speed in the cooling device directory so I created its own issue since it might be more involved. @JakeRoggenbuck @Shuzhengz
|
Tested, everything works great! |
Closes #341