-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daemon Hooking #353
Daemon Hooking #353
Conversation
Yay! very well done! |
The solution that I decided to use was to replace most of the references to the |
I've implemented the command listening and parsing. You can now use socat to broadcast |
Ok, this PR is almost complete. It needs a LOT of reviews there are so many situations where it can break and it's quite unstable. |
its still a draft pr cant review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also don't forget about cargo fmt
This looks very close to being done, if not already done. Anything else you think would be good to add? |
It needs to be stabilized lots of unhandled exceptions. |
Almost done, just fixed a major bug! |
Looks like we are go for review @JakeRoggenbuck and @Shuzhengz! The daemon hooking is working, please re-review then merge this! |
Awesome! |
What is a good way to test the sending to the socket? |
Cargo monit attempts to send the hello packet. It will then print out the response to std out ( you will need to scroll up because it gets pushed away by the TUI ) you can test by reading that response. Additionally you can use socat to manually attach to the sock and send packets yourself. |
Tested, everything seems good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
No description provided.