Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] First iteration of OOing Battery #393

Merged
merged 2 commits into from
Aug 15, 2022
Merged

[RFC] First iteration of OOing Battery #393

merged 2 commits into from
Aug 15, 2022

Conversation

blackduckx
Copy link
Contributor

  • Create a new Battery Class in power
  • Setup most of the battery related functions to the class
  • Fix a possible bugs in battery condition lookups
    My laptop does not have energy_full* sys controls
    but charge_full* sys controls

@blackduckx
First iteration of OOing Battery
06cd8a2 
* Create a new Battery Class in power
* Setup most of the battery related functions to the class
* Fix a possible bugs in battery condition lookups
  My laptop does not have energy_full* sys controls
  but charge_full* sys controls
@blackduckx
Cargo fmt the current code
ca11b15
@blackduckx blackduckx changed the title [RFS] First iteration of OOing Battery [RFC] First iteration of OOing Battery Aug 15, 2022
JakeRoggenbuck
JakeRoggenbuck reviewed Aug 15, 2022
View reviewed changes
Copy link
Owner

@JakeRoggenbuck JakeRoggenbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I will be able to test this in a few hours. I can also see if I can get someone else to test in the mean time. Great work!

Camerooooon
Camerooooon approved these changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@Camerooooon Camerooooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here is tested and looks amazing. I noticed some things that need to be further iterated which I listed in a new issue. It looks like these issues arose as a consequence of switching to an object-oriented model in addition to what was already present in our codebase. I listed what I noticed in #394 if you would like to take a look and maybe work on them.

Thank you so much for doing this, I believe switching the battery to object-oriented is a great way to improve the codebase.

JakeRoggenbuck
JakeRoggenbuck approved these changes Aug 15, 2022
View reviewed changes
Copy link
Owner

@JakeRoggenbuck JakeRoggenbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done! Looks great.

@JakeRoggenbuck JakeRoggenbuck merged commit 53b9598 into JakeRoggenbuck:main Aug 15, 2022
@blackduckx
Copy link
Contributor Author

Thank you guys for taking care of this chunk of code.
I had no luck to moving forward with this code this Week, but @Camerooooon & @JakeRoggenbuck you already did ;)

You definitly had the spirit ! One step forward, even not perfect. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camerooooon Camerooooon Camerooooon approved these changes

@JakeRoggenbuck JakeRoggenbuck JakeRoggenbuck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@blackduckx @JakeRoggenbuck @Camerooooon