Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase terseness and improve error handling #91

Merged
merged 2 commits into from
Sep 13, 2021
Merged

Increase terseness and improve error handling #91

merged 2 commits into from
Sep 13, 2021

Conversation

JakeRoggenbuck
Copy link
Owner

@JakeRoggenbuck JakeRoggenbuck commented Sep 13, 2021 •
edited
Loading

fixes #75

Camerooooon
Camerooooon approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@Camerooooon Camerooooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles and runs properly, looks good to me!

@JakeRoggenbuck JakeRoggenbuck mentioned this pull request Sep 13, 2021
Closed
@JakeRoggenbuck
Copy link
Owner Author

JakeRoggenbuck commented Sep 13, 2021 •
edited
Loading

Works! (after merge)

@JakeRoggenbuck JakeRoggenbuck merged commit 8f2d799 into main Sep 13, 2021
@Shuzhengz Shuzhengz deleted the get-set-terseness branch February 15, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Camerooooon Camerooooon Camerooooon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The get and set commands are very repetitive
2 participants
@JakeRoggenbuck @Camerooooon