Skip to content

Merge pull request #329 from JakeStanger/dependabot/cargo/regex-1.10.2

Sign in for the full log view
GitHub Actions / clippy succeeded Oct 16, 2023 in 0s

clippy

5 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 5
Note 0
Help 0

Versions

  • rustc 1.73.0 (cc66ad468 2023-10-03)
  • cargo 1.73.0 (9c4383fb5 2023-08-26)
  • clippy 0.1.73 (cc66ad4 2023-10-03)

Annotations

Check warning on line 183 in src/desktop_file.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `or_insert_with` to construct default value

warning: use of `or_insert_with` to construct default value
   --> src/desktop_file.rs:183:18
    |
183 |                 .or_insert_with(Vec::new)
    |                  ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
    = note: `#[warn(clippy::unwrap_or_default)]` on by default

Check warning on line 88 in src/modules/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

associated function `new` is never used

warning: associated function `new` is never used
  --> src/modules/mod.rs:88:8
   |
87 | impl<W: IsA<Widget>> ModuleParts<W> {
   | ----------------------------------- associated function in this implementation
88 |     fn new(widget: W, popup: Option<ModulePopupParts>) -> Self {
   |        ^^^

Check warning on line 14 in src/error.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

constant `ERR_WAYLAND_DATA` is never used

warning: constant `ERR_WAYLAND_DATA` is never used
  --> src/error.rs:14:11
   |
14 | pub const ERR_WAYLAND_DATA: &str = "Failed to get data for Wayland object";
   |           ^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 170 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
   --> src/main.rs:170:9
    |
170 |     let mut config = env::var("IRONBAR_CONFIG")
    |         ----^^^^^^
    |         |
    |         help: remove this `mut`
    |
    = note: `#[warn(unused_mut)]` on by default

Check warning on line 20 in src/clients/wayland/wl_seat.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `qh`

warning: unused variable: `qh`
  --> src/clients/wayland/wl_seat.rs:20:9
   |
20 |         qh: &QueueHandle<Self>,
   |         ^^ help: if this is intentional, prefix it with an underscore: `_qh`
   |
   = note: `#[warn(unused_variables)]` on by default