Skip to content
This repository has been archived by the owner on Jan 14, 2019. It is now read-only.

Bug in directive logic #102

Closed
JamesHenry opened this issue Jan 6, 2019 · 2 comments · Fixed by #103
Closed

Bug in directive logic #102

JamesHenry opened this issue Jan 6, 2019 · 2 comments · Fixed by #103
Labels

Comments

@JamesHenry
Copy link
Owner

JamesHenry commented Jan 6, 2019

@armano2 I discovered an issues with #65

("use strict");

Should not be treated as a directive, it currently is. We lose the fact it is a ParenthesizedExpression completely during the conversion process which is why something like this is easy to miss.

This is one of the things babel uses the extra property for on the AST - it tracks "parenthesized": true

@JamesHenry
Copy link
Owner Author

It's super frustrating not to have this information in the AST - I see someone has even opened an issue on ESTree proposing it

@JamesHenry
Copy link
Owner Author

🎉 This issue has been resolved in version 13.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant