Skip to content
This repository has been archived by the owner on Jan 14, 2019. It is now read-only.

fix: Fix issues with parsing types and directives #65

Merged
merged 25 commits into from
Dec 28, 2018

Conversation

armano2
Copy link
Contributor

@armano2 armano2 commented Dec 26, 2018

This PR contains fixes related to parsing types and fix for parsing directives.

Changelog:


This PR contains changes from: #63, #56, #62, #61, #55

i made one PR out of all of those changes, to test if everything is going to work correctly when all of them are applied at same time


@j-f1 @uniqueiniquity @JamesHenry

fixes: #16 #2 #64

@armano2 armano2 changed the title Alignment: fix issues in parser Alignment: fix issues in converter Dec 26, 2018
Additionally fix issue that Object literal is not TypeReference
@armano2 armano2 changed the title Alignment: fix issues in converter fix: Fix issues with parsing types and directives Dec 26, 2018
src/convert.ts Outdated Show resolved Hide resolved
uniqueiniquity
uniqueiniquity previously approved these changes Dec 26, 2018
@armano2
Copy link
Contributor Author

armano2 commented Dec 27, 2018

@uniqueiniquity i found bug that directives inside modules and namespaces was not marked as such
(i had to to fix for that).

see: https://github.com/Microsoft/TypeScript/wiki/What%27s-new-in-TypeScript#modules-are-now-emitted-with-a-use-strict-prologue


and for now i'm not fixing other issues, this commit is to big anyway...

@JamesHenry
Copy link
Owner

@armano2 Should I wait until you let me know you are ready? Thanks again for all the hard work

@armano2
Copy link
Contributor Author

armano2 commented Dec 27, 2018

@JamesHenry this pr is completed, and issue with modules/namespaces got solved in 5b6632d

Copy link
Owner

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again, @armano2! This is some huge progress.

Hopefully in future we can avoid such large PRs as it doesn't work so well with the semantic-release concept, but I appreciate you have folded together multiple streams of work that I hadn't had chance to take a look at separately (due to being on Christmas vacation).

There are also breaking changes within this which are not actually called out I don't think, so I am going to mark the whole thing are "breaking" and refer people back to this PR to get full details.

I'm sure typescript-eslint-parser and prettier will need some updates after this!

@JamesHenry JamesHenry merged commit 969c0d3 into JamesHenry:master Dec 28, 2018
@JamesHenry
Copy link
Owner

🎉 This PR is included in version 8.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@armano2 armano2 deleted the aligment branch December 28, 2018 18:30
@armano2
Copy link
Contributor Author

armano2 commented Dec 28, 2018

@JamesHenry had no support for those nodes, and i just pushed PR witch add them to visitor keys in
eslint/typescript-eslint-parser@34adb5d

@armano2
Copy link
Contributor Author

armano2 commented Dec 28, 2018

i will try doing smaller patches now :)

@JamesHenry JamesHenry mentioned this pull request Jan 6, 2019
JamesHenry pushed a commit to typescript-eslint/typescript-eslint that referenced this pull request Jan 13, 2019
BREAKING CHANGE: We apologise for the lack of a granular changelog here. There are multiple changes to the AST in this large commit, please see the PR JamesHenry/typescript-estree#65 for full details
JamesHenry pushed a commit to typescript-eslint/typescript-eslint that referenced this pull request Jan 13, 2019
BREAKING CHANGE: We apologise for the lack of a granular changelog here. There are multiple changes to the AST in this large commit, please see the PR JamesHenry/typescript-estree#65 for full details
JamesHenry pushed a commit to typescript-eslint/typescript-eslint that referenced this pull request Jan 13, 2019
BREAKING CHANGE: We apologise for the lack of a granular changelog here. There are multiple changes to the AST in this large commit, please see the PR JamesHenry/typescript-estree#65 for full details
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for TSTupleType and TSAbstractClassDeclaration in ast-node-types.js
3 participants