Skip to content
This repository has been archived by the owner on Jan 14, 2019. It is now read-only.

[Suggestion] Nightly builds #39

Open
corbinu opened this issue Nov 30, 2018 · 6 comments
Open

[Suggestion] Nightly builds #39

corbinu opened this issue Nov 30, 2018 · 6 comments

Comments

@corbinu
Copy link

corbinu commented Nov 30, 2018

I was wondering if it would be possible to setup nightly builds? I am going to suggest this in typescript-eslint-parser also.

This would be really for use with the nightly typescript version and only for those that want to be on the bleeding edge. This would obviously only be valuable if typescript-eslint-parser is amenable.

I am happy to help!

@j-f1
Copy link
Contributor

j-f1 commented Dec 1, 2018

The package could also add a prepare script that compiles the TS, and people could install JamesHenry/typescript-estree. npm will automatically install devDependencies when a package is installed from Git and the prepare script is present.

@corbinu
Copy link
Author

corbinu commented Dec 1, 2018

@j-f1 A good idea but I do feel like that when a new version comes out (like 3.2 just did) I would have to maintain my own fork of typescript-eslint-parser (something I do do now) and then switch the package to that branch when it is created

@JamesHenry
Copy link
Owner

JamesHenry commented Dec 1, 2018 via email

@corbinu
Copy link
Author

corbinu commented Dec 1, 2018

Well my thought is this would be targeting typescript nightly so BigInt could be merged onto a nightly branch as soon as it was ready. Then when 3.2 was released you would actually create the 3.2 PR out of the nightly branch features that had stabilized.

@corbinu
Copy link
Author

corbinu commented Dec 1, 2018

Not at all trying to make more work for you though. Was hoping it could be totally automated and just thought it would a be a way for a subset of users to make PRs and see quick results while keeping the mainline releases stable. Especially given now we have 3 closely related products with separate teams.

@armano2
Copy link
Contributor

armano2 commented Dec 1, 2018

@JamesHenry @corbinu i'm refactoring types used in convert.ts, we are going to have type checking if AST from typescript didn't change. It's going to help with nightly builds :>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants