-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#29 Implementing automated code review and style guide #30
Conversation
Will ignore travis reviews for now as testing is not yet implemented (will work on soon after completing this issue) |
Tailor dev stated that you cannot set those options in the yml
This is coming with a lot of commits as they were necessary for testing but unfortunately for version control that makes this PR a bit of a mess. QA'd in sim extensively as this PR refactors almost every file in the project. Will add tests soon after this to the project so changes like this are less risky. Will check now if Codacy shows any errors on this PR and if not will merge |
Looks like the branch has about 100 issues outstanding down from 500, most appear to be from files ignored by the .tailor.yml file (mostly xcode native code such as progressBar.swift) will merge so codacy can also use the yml then hotfix any issues that may be needed referencing the issue and this PR if needed |
Testing PR for now to test Codacy's code review