Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#29 Implementing automated code review and style guide #30

Merged
merged 48 commits into from
Mar 6, 2018
Merged

Conversation

JamesLongman
Copy link
Owner

Testing PR for now to test Codacy's code review

@JamesLongman
Copy link
Owner Author

Will ignore travis reviews for now as testing is not yet implemented (will work on soon after completing this issue)

Repository owner deleted a comment Mar 6, 2018
Repository owner deleted a comment Mar 6, 2018
JamesLongman and others added 2 commits March 6, 2018 17:30
Tailor dev stated that you cannot set those options in the yml
Repository owner deleted a comment Mar 6, 2018
Repository owner deleted a comment Mar 6, 2018
Repository owner deleted a comment Mar 6, 2018
Repository owner deleted a comment Mar 6, 2018
@JamesLongman
Copy link
Owner Author

JamesLongman commented Mar 6, 2018

This is coming with a lot of commits as they were necessary for testing but unfortunately for version control that makes this PR a bit of a mess. QA'd in sim extensively as this PR refactors almost every file in the project. Will add tests soon after this to the project so changes like this are less risky. Will check now if Codacy shows any errors on this PR and if not will merge

Repository owner deleted a comment Mar 6, 2018
@JamesLongman
Copy link
Owner Author

Looks like the branch has about 100 issues outstanding down from 500, most appear to be from files ignored by the .tailor.yml file (mostly xcode native code such as progressBar.swift) will merge so codacy can also use the yml then hotfix any issues that may be needed referencing the issue and this PR if needed

@JamesLongman JamesLongman merged commit 4f86c2c into develop Mar 6, 2018
@JamesLongman JamesLongman deleted the #29 branch March 7, 2018 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant