Fix: Run 'composer cs'

Jan0707 · Dec 27, 2019 · f617186 · f617186
1 parent 096b413
commit f617186
Show file tree

Hide file tree

Showing 6 changed files with 49 additions and 36 deletions.
diff --git a/src/Extension/ObjectProphecyRevealDynamicReturnTypeExtension.php b/src/Extension/ObjectProphecyRevealDynamicReturnTypeExtension.php
@@ -21,15 +21,17 @@ public function getClass(): string
 
     public function isMethodSupported(MethodReflection $methodReflection): bool
     {
-        return $methodReflection->getName() === 'reveal';
+        return 'reveal' === $methodReflection->getName();
     }
 
     /**
      * @param MethodReflection $methodReflection
-     * @param MethodCall $methodCall
-     * @param Scope $scope
-     * @return Type
+     * @param MethodCall       $methodCall
+     * @param Scope            $scope
+     *
      * @throws \PHPStan\ShouldNotHappenException
+     *
+     * @return Type
      */
     public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): Type
     {

diff --git a/src/Extension/ProphetProphesizeDynamicReturnTypeExtension.php b/src/Extension/ProphetProphesizeDynamicReturnTypeExtension.php
@@ -15,8 +15,9 @@
 
 class ProphetProphesizeDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension
 {
-
-    /** @var string */
+    /**
+     * @var string
+     */
     private $className;
 
     public function __construct(string $className)
@@ -31,22 +32,24 @@ public function getClass(): string
 
     public function isMethodSupported(MethodReflection $methodReflection): bool
     {
-        return $methodReflection->getName() === 'prophesize';
+        return 'prophesize' === $methodReflection->getName();
     }
 
     /**
      * @param MethodReflection $methodReflection
-     * @param MethodCall $methodCall
-     * @param Scope $scope
-     * @return Type
+     * @param MethodCall       $methodCall
+     * @param Scope            $scope
+     *
      * @throws \PHPStan\ShouldNotHappenException
+     *
+     * @return Type
      */
     public function getTypeFromMethodCall(MethodReflection $methodReflection, MethodCall $methodCall, Scope $scope): Type
     {
         $parametersAcceptor = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants());
         $prophecyType = $parametersAcceptor->getReturnType();
 
-        if (\count($methodCall->args) === 0) {
+        if (0 === \count($methodCall->args)) {
             return $prophecyType;
         }
 
@@ -62,11 +65,11 @@ public function getTypeFromMethodCall(MethodReflection $methodReflection, Method
             throw new ShouldNotHappenException();
         }
 
-        if ($class === 'static') {
+        if ('static' === $class) {
             return $prophecyType;
         }
 
-        if ($class === 'self' && $scope->getClassReflection() !== null) {
+        if ('self' === $class && null !== $scope->getClassReflection()) {
             $class = $scope->getClassReflection()->getName();
         }
 

diff --git a/src/PhpDoc/TypeNodeResolverExtension.php b/src/PhpDoc/TypeNodeResolverExtension.php
@@ -14,8 +14,9 @@
 
 class TypeNodeResolverExtension implements \PHPStan\PhpDoc\TypeNodeResolverExtension, TypeNodeResolverAwareExtension
 {
-
-    /** @var TypeNodeResolver */
+    /**
+     * @var TypeNodeResolver
+     */
     private $typeNodeResolver;
 
     public function setTypeNodeResolver(TypeNodeResolver $typeNodeResolver): void
@@ -34,13 +35,15 @@ public function resolve(TypeNode $typeNode, NameScope $nameScope): ?Type
             return null;
         }
 
-        if (count($typeNode->types) === 2) {
+        if (2 === \count($typeNode->types)) {
             $objectProphecyType = null;
             $prophesizedType = null;
+
             foreach ($typeNode->types as $innerType) {
                 $type = $this->typeNodeResolver->resolve($innerType, $nameScope);
+
                 if ($type instanceof TypeWithClassName) {
-                    if ($type->getClassName() === ObjectProphecy::class) {
+                    if (ObjectProphecy::class === $type->getClassName()) {
                         $objectProphecyType = $type;
                     } else {
                         $prophesizedType = $type;
@@ -50,7 +53,7 @@ public function resolve(TypeNode $typeNode, NameScope $nameScope): ?Type
                 }
             }
 
-            if ($objectProphecyType !== null && $prophesizedType !== null) {
+            if (null !== $objectProphecyType && null !== $prophesizedType) {
                 return new ObjectProphecyType($prophesizedType->getClassName());
             }
         }

diff --git a/src/Reflection/ProphecyMethodsClassReflectionExtension.php b/src/Reflection/ProphecyMethodsClassReflectionExtension.php
@@ -12,7 +12,7 @@ public function hasMethod(ClassReflection $classReflection, string $methodName):
     {
         // don't know which class is prophesized here, so let's say yes to every method
         // must match class in MockBuilderType parent::__construct() equivalent
-        return $classReflection->getName() === 'Prophecy\Prophecy\ObjectProphecy';
+        return 'Prophecy\Prophecy\ObjectProphecy' === $classReflection->getName();
     }
 
     public function getMethod(ClassReflection $classReflection, string $methodName): MethodReflection

diff --git a/src/Type/ObjectProphecyType.php b/src/Type/ObjectProphecyType.php
@@ -23,22 +23,23 @@ public function __construct(string $prophesizedClass)
         parent::__construct('Prophecy\Prophecy\ObjectProphecy');
     }
 
-    public function describe(VerbosityLevel $level): string
-    {
-        return sprintf('%s<%s>', parent::describe($level), $this->prophesizedClass);
-    }
-
-    public function getProphesizedClass(): string
-    {
-        return $this->prophesizedClass;
-    }
-
     /**
      * @param mixed[] $properties
+     *
      * @return self
      */
     public static function __set_state(array $properties): Type
     {
         return new self($properties['prophesizedClass']);
     }
+
+    public function describe(VerbosityLevel $level): string
+    {
+        return \sprintf('%s<%s>', parent::describe($level), $this->prophesizedClass);
+    }
+
+    public function getProphesizedClass(): string
+    {
+        return $this->prophesizedClass;
+    }
 }
diff --git a/tests/Test/BaseModelTest.php b/tests/Test/BaseModelTest.php
@@ -7,7 +7,11 @@
 use Prophecy\Prophecy\ObjectProphecy;
 use Tests\Model\BaseModel;
 
-class BaseModelTest extends TestCase
+/**
+ * @internal
+ * @coversNothing
+ */
+final class BaseModelTest extends TestCase
 {
     /**
      * @var BaseModel|ObjectProphecy
@@ -21,8 +25,8 @@ public function testBasicProperty(): void
         $subject = new BaseModel();
         $subject->setFoo($word);
 
-        $this->assertEquals($word, $subject->getFoo());
-        $this->assertEquals(4, $subject->doubleTheNumber(2));
+        self::assertEquals($word, $subject->getFoo());
+        self::assertEquals(4, $subject->doubleTheNumber(2));
     }
 
     public function testWithProphecy(): void
@@ -32,8 +36,8 @@ public function testWithProphecy(): void
 
         $subject->doubleTheNumber(Argument::is(2))->willReturn(5);
 
-        $this->assertEquals('bar', $subject->reveal()->getFoo());
-        $this->assertEquals(5, $subject->reveal()->doubleTheNumber(2));
+        self::assertEquals('bar', $subject->reveal()->getFoo());
+        self::assertEquals(5, $subject->reveal()->doubleTheNumber(2));
     }
 
     /**
@@ -51,7 +55,7 @@ public function testProphesizedAttributesShouldAlsoWork(): void
 
         $subject = $this->subject->reveal();
 
-        $this->assertEquals('bar', $subject->getFoo());
-        $this->assertEquals(5, $subject->doubleTheNumber(2));
+        self::assertEquals('bar', $subject->getFoo());
+        self::assertEquals(5, $subject->doubleTheNumber(2));
     }
 }