Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cache): create the .cache folder when non existant #5758

Closed
1 task done
netbix opened this issue Oct 19, 2024 · 9 comments
Closed
1 task done

feat(cache): create the .cache folder when non existant #5758

netbix opened this issue Oct 19, 2024 · 9 comments
Assignees
Labels
🤩 enhancement Improvement of a feature

Comments

@netbix
Copy link

netbix commented Oct 19, 2024

Code of Conduct

  • I agree to follow this project's Code of Conduct

What happened?

if the .cache folder does not exist during installation, the software will not install correctly.
Furthermore, these files are continuously created in the root:
omp.cache.9e82fb6d-f453-4846-a531-0afd015fefb1 omp.cache omp.cache.9823a730-3764-41e1-bf68-8f4e8fd38890 themes

Theme

default theme

What OS are you seeing the problem on?

Linux

Which shell are you using?

bash

Log output

[root@veeamproxy ~]# curl -s https://ohmyposh.dev/install.sh | bash -s
⚠️  Installation directory /root/.local/bin is not in your $PATH, add it using 
export PATH=$PATH:/root/.local/bin

ℹ️  Installing oh-my-posh for linux-amd64 in /root/.local/bin
⬇️  Downloading oh-my-posh from https://github.com/JanDeDobbeleer/oh-my-posh/releases/latest/download/posh-linux-amd64
🎨 Installing oh-my-posh themes in /root/themes         <<<<-----------------???

🚀 Installation complete.

You can follow the instructions at https://ohmyposh.dev/docs/installation/prompt
to setup your shell to use oh-my-posh.

If you want to use a built-in theme, you can find them in the /root/themes directory:
  oh-my-posh init {shell} --config /root/themes/{theme}.omp.json

[root@veeamproxy ~]# ls
anaconda-ks.cfg  themes
@netbix netbix added the 🐛 bug Something isn't working label Oct 19, 2024
@JanDeDobbeleer
Copy link
Owner

if the .cache folder does not exist during installation, the software will not install correctly.

@netbix what does this mean? I see everything did install based on the output. We look for a few places for cache data based on existing standards, and default to HOME when none are found by design. You can set OMP_CACHE_DIR, or XDG_CACHE_HOME based on what you prefer to define the cache directory.

@netbix
Copy link
Author

netbix commented Oct 19, 2024

I get it, I'm just saying it would be nicer if the .cache folder was created during the install. Furthermore, every time you enter the shell and exit, all cache files are left behind.
immagine

@netbix
Copy link
Author

netbix commented Oct 19, 2024

Thanks for your answer anyway.

@JanDeDobbeleer
Copy link
Owner

@netbix they will be cleaned after 7 days with the next major version. I noticed that as well, will be solved.

On the request, I guess that's a good idea. Didn't consider that previously, but check. Why not indeed.

@JanDeDobbeleer JanDeDobbeleer added 🤩 enhancement Improvement of a feature and removed 🐛 bug Something isn't working labels Oct 19, 2024
@JanDeDobbeleer JanDeDobbeleer changed the title Problem on install if .cache folder does not exist feat(cache): create the .cache folder does not exist Oct 19, 2024
@JanDeDobbeleer JanDeDobbeleer changed the title feat(cache): create the .cache folder does not exist feat(cache): create the .cache folder when non existant Oct 19, 2024
@netbix
Copy link
Author

netbix commented Oct 19, 2024

thanks for your nice work!

@kunaaal13
Copy link

kunaaal13 commented Oct 22, 2024

if the .cache folder does not exist during installation, the software will not install correctly.

@netbix what does this mean? I see everything did install based on the output. We look for a few places for cache data based on existing standards, and default to HOME when none are found by design. You can set OMP_CACHE_DIR, or XDG_CACHE_HOME based on what you prefer to define the cache directory.

Screenshot 2024-10-22 at 2 03 33 PM @JanDeDobbeleer where to add this OMP_CACHE_DIR because my root folder has become mess

@JanDeDobbeleer
Copy link
Owner

It's an environment variable, you can set to any folder you like.

@JanDeDobbeleer
Copy link
Owner

Solved in #5686, you can download the build there. Actual release pending for the next week(s).

@netbix
Copy link
Author

netbix commented Dec 15, 2024

@netbix they will be cleaned after 7 days with the next major version. I noticed that as well, will be solved.

On the request, I guess that's a good idea. Didn't consider that previously, but check. Why not indeed.

Is the omp.cache file cleaning problem solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤩 enhancement Improvement of a feature
Projects
None yet
Development

No branches or pull requests

3 participants