Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: in react segment added check for the react package presence #5894

Merged
merged 1 commit into from
Nov 16, 2024
Merged

fix: in react segment added check for the react package presence #5894

merged 1 commit into from
Nov 16, 2024

Conversation

ernstc
Copy link
Contributor

@ernstc ernstc commented Nov 15, 2024

Prerequisites

  • I have read and understood the [contributing guide][CONTRIBUTING.md].
  • The commit message follows the [conventional commits][cc] guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Description

In react segment, added check for the react package presence, so that when the react package is not referenced, the segment is disabled.

@JanDeDobbeleer JanDeDobbeleer merged commit e79db4a into JanDeDobbeleer:main Nov 16, 2024
13 checks passed
@ernstc ernstc deleted the fix/react-segment branch November 16, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ernstc @JanDeDobbeleer