Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore: bump softprops/action-gh-release from 2.1.0 to 2.2.0" #6017

Conversation

suzuki-shunsuke
Copy link
Contributor

@suzuki-shunsuke suzuki-shunsuke commented Dec 14, 2024

Close #6018

This reverts commit 85d2be2.

The release failed due to the bug of softprops/action-gh-release.

Run softprops/action-gh-release@7b4da11513bf3f43f9999e90eabced41ab8bb048
👩‍🏭 Creating new GitHub release for tag v24.13.0...
⬆️ Uploading version.txt...
⬆️ Uploading themes.zip...
⬆️ Uploading posh-windows-arm64.exe...
⬆️ Uploading posh-windows-amd64.exe...
⬆️ Uploading posh-windows-386.exe...
⬆️ Uploading posh-linux-arm64...
⬆️ Uploading posh-linux-arm...
⬆️ Uploading posh-linux-amd64...
⬆️ Uploading posh-linux-386...
⬆️ Uploading posh-freebsd-arm64...
⬆️ Uploading posh-freebsd-arm...
⬆️ Uploading posh-freebsd-amd64...
⬆️ Uploading posh-freebsd-386...
⬆️ Uploading posh-darwin-arm64...
⬆️ Uploading posh-darwin-amd64...
⬆️ Uploading install-x86.msi.sha256...
⬆️ Uploading install-x86.msi...
⬆️ Uploading install-x64.msi.sha256...
⬆️ Uploading install-x64.msi...
⬆️ Uploading install-arm64.msi.sha256...
⬆️ Uploading install-arm64.msi...
⬆️ Uploading checksums.txt.sig...
⬆️ Uploading checksums.txt...
Error: Request body length does not match content-length header

softprops/action-gh-release v2.2.0 has a known issue.

Prerequisites

  • I have read and understood the contributing guide.
  • The commit message follows the conventional commits guidelines.
  • Tests for the changes have been added (for bug fixes / features).
  • Docs have been added/updated (for bug fixes / features).

Description

@suzuki-shunsuke
Copy link
Contributor Author

This pr downgrades action-gh-release.
My concern is that Dependabot may update it to v2.2.0 again.
I usually use Renovate, so I'm not familiar with Dependabot.

@JanDeDobbeleer
Copy link
Owner

@suzuki-shunsuke it will update it for sure. Don't they have a fix ready to go for this? I can only look at this in the morning unfortunately.

@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Dec 14, 2024

Don't they have a fix ready to go for this?

The issue is still open.
I can't find any work to resolve this issue.
The default branch hasn't been updated after releasing 2.2.0, there is no reply from maintainers, and there is no pr to resolve this issue.

softprops/action-gh-release@v2 is pointing v2.0.9, not v2.2.0.

@suzuki-shunsuke
Copy link
Contributor Author

suzuki-shunsuke commented Dec 14, 2024

752d2ac I've updated Dependabot setting to ignore softprops/action-gh-release 2.2.0.

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuring-dependabot-version-updates#example-disabling-version-updates-for-some-dependencies

I've confirmed the setting works well.

https://github.com/suzuki-shunsuke/test-dependabot/blob/5f6fe0773a12569a003c3e696929539ce76f4941/.github/dependabot.yml#L1-L11
https://github.com/suzuki-shunsuke/test-dependabot/actions/runs/12334016873/job/34423641417

updater | 2024/12/14 23:42:23 INFO <job_932709362> Checking if softprops/action-gh-release 2.1.0 needs updating
updater | 2024/12/14 23:42:23 INFO <job_932709362> Ignored versions:
2024/12/14 23:42:23 INFO <job_932709362>   2.2.0 - from .github/dependabot.yml
  proxy | 2024/12/14 23:42:23 [014] GET [https://github.com:443/softprops/action-gh-release.git/info/refs?service=git-upload-pack](https://github.com/softprops/action-gh-release.git/info/refs?service=git-upload-pack)
2024/12/14 23:42:23 [014] 200 [https://github.com:443/softprops/action-gh-release.git/info/refs?service=git-upload-pack](https://github.com/softprops/action-gh-release.git/info/refs?service=git-upload-pack)
updater | 2024/12/14 23:42:23 INFO <job_932709362> All updates for softprops/action-gh-release were ignored

@JanDeDobbeleer JanDeDobbeleer force-pushed the rollback-action-gh-release-210 branch from 752d2ac to d1f383a Compare December 15, 2024 10:40
@JanDeDobbeleer JanDeDobbeleer merged commit 8a2db6e into JanDeDobbeleer:main Dec 15, 2024
8 checks passed
@suzuki-shunsuke suzuki-shunsuke deleted the rollback-action-gh-release-210 branch December 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v24.13.0 failed due to the bug of softprops/action-gh-release
2 participants