-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: add ability to build extension for ocis apps-loading #32
Conversation
aebe76a
to
c17688f
Compare
c17688f
to
2c83243
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -0,0 +1,5 @@ | |||
{ | |||
"id": "com.github.jankaritech.web.mdpresentation", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id
line should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using it in other files but yeah better move it to index.ts. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, No. we need it in vite config as well. Could cause trouble to put it in src/index.ts
@kulmann Does ocis process id
in manifest file?
If no and if it doesn't harm then we want to keep it there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oCIS doesn't process an id
prop from the manifest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks
Added the option to build the extension for apps loading feature supported by ocis.
Now, to build the extension, we have a new
APPS_LOADING
env variable to switch between the build types.pnpm build
(Default) - build for extension serverAPPS_LOADING=true pnpm build
- extension can be loaded by oCIS usingWEB_ASSET_APPS_PATH
Needs: owncloud/ocis#8523
Fixes #31, fixes #30, fixes #45