Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: setup e2e ci pipeline #51

Merged
merged 2 commits into from
May 9, 2024
Merged

ci: setup e2e ci pipeline #51

merged 2 commits into from
May 9, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented May 7, 2024 •
edited
Loading

Description

Added e2e tests pipeline in CI

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)
  • Documentation only (no source changes)
  • Maintenance (e.g. dependency updates or tooling)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation updated

@saw-jan
refactor: move package.json into e2e
dbd867d
@saw-jan
ci: setup e2e in github action
e8f2f63 
ci: add ocis service

ci: run in headless

ci: fix server urls
@saw-jan saw-jan changed the title ci: setup e2e CI pipeline ci: setup e2e ci pipeline May 7, 2024
@saw-jan saw-jan marked this pull request as ready for review May 7, 2024 11:06
@saw-jan saw-jan added the QA label May 7, 2024
@saw-jan saw-jan mentioned this pull request May 7, 2024
Open
10 tasks
koebel
koebel reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@koebel koebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but get some reviews from others who have more experience with CI too :)

@S-Panta
Copy link
Contributor

S-Panta commented May 9, 2024

Looks Good

phil-davis
phil-davis approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the lint, build and e2e tests all ran and passed.

@saw-jan saw-jan merged commit a9a3f6c into main May 9, 2024
1 check passed
@saw-jan saw-jan deleted the ci/build-e2e-ci branch May 9, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koebel koebel koebel left review comments

@phil-davis phil-davis phil-davis approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@S-Panta S-Panta Awaiting requested review from S-Panta

Assignees
No one assigned
Labels
QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saw-jan @S-Panta @phil-davis @koebel