Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upload production ready extension artifacts as the release assets #64

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jul 17, 2024

Description

Whenever there's a release, upload the necessary artifacts to the release assets. These assets will be added:

  • mdpresentation-{release_tag}.zip
  • md5sum.txt
  • sha256sum.txt

Related Issue

Screenshots (if appropriate):

Screenshot from 2024-07-17 17-10-44

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Tests only (no source changes)
  • Documentation only (no source changes)
  • Maintenance (e.g. dependency updates or tooling)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation updated

@saw-jan saw-jan force-pushed the ci/publish-release-artifacts branch 2 times, most recently from f44032c to 98dd175 Compare July 17, 2024 11:14
@saw-jan saw-jan changed the title ci: share dist artifacts between jobs ci: upload production ready extension artifacts as the release assets Jul 17, 2024
@saw-jan saw-jan marked this pull request as ready for review July 17, 2024 11:18
@saw-jan saw-jan requested a review from S-Panta July 17, 2024 11:18
@saw-jan saw-jan force-pushed the ci/publish-release-artifacts branch from 98dd175 to 559f015 Compare July 17, 2024 11:22
Copy link
Contributor

@S-Panta S-Panta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

with:
name: dist
path: dist/
retention-days: 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to choose 1 day for artifact retention time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need it once it is added to release assets

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this artifact and release assets are different things

@saw-jan saw-jan merged commit 0c27582 into main Jul 18, 2024
3 checks passed
@saw-jan saw-jan deleted the ci/publish-release-artifacts branch July 18, 2024 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Append production ready zip file of extension in the release tags
2 participants