-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: upload production ready extension artifacts as the release assets #64
Conversation
ci: upload artifacts
f44032c
to
98dd175
Compare
98dd175
to
559f015
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
with: | ||
name: dist | ||
path: dist/ | ||
retention-days: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to choose 1 day for artifact retention time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't need it once it is added to release assets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this artifact and release assets are different things
Description
Whenever there's a release, upload the necessary artifacts to the release assets. These assets will be added:
mdpresentation-{release_tag}.zip
md5sum.txt
sha256sum.txt
Related Issue
Screenshots (if appropriate):
Types of changes
Checklist: