Skip to content
This repository has been archived by the owner on Oct 15, 2023. It is now read-only.

Add gremlin-console containers to compose configuration and support in entrypoint #21

Closed

Conversation

bramford
Copy link

I found the user experience rather difficult when getting a gremlin console going (both remotely and directly). Especially for the CQL/ES storage backend.

I figured it'd be nice to have the gremlin console built in to the janusgraph image entrypoint and to provide containers in the compose files.

I ran update.sh but didn't commit the change in JANUS_VERSION. Feel free to run it and add another commit as required.

@janusgraph-bot
Copy link

Committer of one or more commits is not listed as a CLA signer, either individual or as a member of an organization.

@bramford bramford force-pushed the fixes-for-gremlin-console branch from 87822fb to f0947b9 Compare June 19, 2019 21:57
@JanusGraph JanusGraph deleted a comment Jun 19, 2019
@JanusGraph JanusGraph deleted a comment Jun 19, 2019
@JanusGraph JanusGraph deleted a comment Jun 19, 2019
@janusgraph-bot
Copy link

Committer of one or more commits is not listed as a CLA signer, either individual or as a member of an organization.

1 similar comment
@janusgraph-bot
Copy link

Committer of one or more commits is not listed as a CLA signer, either individual or as a member of an organization.

@porunov
Copy link
Member

porunov commented Jul 3, 2019

@bramford Thanks for the contribution!

There is a requirement that each contributor must sign a CLA. It isn't automate right now but JanusGraph members are working on it.

To contribute you should:

  1. Sign a CLA. Instructions are here: https://github.com/JanusGraph/legal/blob/master/README.md
  2. Follow this instructions: https://github.com/JanusGraph/janusgraph/blob/master/CONTRIBUTING.md

Please feel free to ask any questions if you have some.

@bramford bramford force-pushed the fixes-for-gremlin-console branch 2 times, most recently from fb8d585 to 2290967 Compare July 17, 2019 12:36
bramford added 5 commits July 18, 2019 09:15
Signed-off-by: Bramford Horton <bram.horton@gmail.com>
This prevents java WARN spam if the default home directory doesn't exist

Signed-off-by: Bramford Horton <bram.horton@gmail.com>
This allows for either of the following to be given as the docker command:

`gremlin-console`
Launches a gremlin console, directly attached to the storage layer of choice.

`gremlin-console-remote`
Launches a gremlin console which attaches to the remote ports that the gremlin
server is exposing.

Signed-off-by: Bramford Horton <bram.horton@gmail.com>
Signed-off-by: Bramford Horton <bram.horton@gmail.com>
Signed-off-by: Bramford Horton <bram.horton@gmail.com>
@bramford bramford force-pushed the fixes-for-gremlin-console branch from 2290967 to 4147c97 Compare July 17, 2019 21:18
@mbrukman
Copy link
Member

CLA addressed in JanusGraph/legal#144

@farodin91
Copy link
Contributor

@bramford @mbrukman What do you think of splitting server and console into two images? This approach is also used by gremlin.

@mbrukman
Copy link
Member

@farodin91 — SGTM!

@FlorianHockmann
Copy link
Member

It has been nearly a year since the last comment here. So, how do we want to proceed? Do we want to close this PR and then create a ticket to split the image into a server image and one for the console?

Or @bramford, do you want to update this PR to introduce a new image for the console?

cc @farodin91

@bramford
Copy link
Author

@FlorianHockmann

My apologies, I haven't touched JanusGraph for a year and I don't have the time to do this at the moment. If I spin up JanusGraph again in the future, I'll have another go at this.

@FlorianHockmann
Copy link
Member

I created a new issue to create a new image for the console: #100. So, we can close this one now.

@bramford, if you want to come back at this to contribute such an image, then that would of course be welcome!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants