-
Notifications
You must be signed in to change notification settings - Fork 86
Add gremlin-console containers to compose configuration and support in entrypoint #21
Conversation
Committer of one or more commits is not listed as a CLA signer, either individual or as a member of an organization. |
87822fb
to
f0947b9
Compare
Committer of one or more commits is not listed as a CLA signer, either individual or as a member of an organization. |
1 similar comment
Committer of one or more commits is not listed as a CLA signer, either individual or as a member of an organization. |
@bramford Thanks for the contribution! There is a requirement that each contributor must sign a CLA. It isn't automate right now but JanusGraph members are working on it. To contribute you should:
Please feel free to ask any questions if you have some. |
fb8d585
to
2290967
Compare
Signed-off-by: Bramford Horton <bram.horton@gmail.com>
This prevents java WARN spam if the default home directory doesn't exist Signed-off-by: Bramford Horton <bram.horton@gmail.com>
This allows for either of the following to be given as the docker command: `gremlin-console` Launches a gremlin console, directly attached to the storage layer of choice. `gremlin-console-remote` Launches a gremlin console which attaches to the remote ports that the gremlin server is exposing. Signed-off-by: Bramford Horton <bram.horton@gmail.com>
Signed-off-by: Bramford Horton <bram.horton@gmail.com>
Signed-off-by: Bramford Horton <bram.horton@gmail.com>
2290967
to
4147c97
Compare
CLA addressed in JanusGraph/legal#144 |
@farodin91 — SGTM! |
It has been nearly a year since the last comment here. So, how do we want to proceed? Do we want to close this PR and then create a ticket to split the image into a server image and one for the console? Or @bramford, do you want to update this PR to introduce a new image for the console? cc @farodin91 |
My apologies, I haven't touched JanusGraph for a year and I don't have the time to do this at the moment. If I spin up JanusGraph again in the future, I'll have another go at this. |
I found the user experience rather difficult when getting a gremlin console going (both remotely and directly). Especially for the CQL/ES storage backend.
I figured it'd be nice to have the gremlin console built in to the janusgraph image entrypoint and to provide containers in the compose files.
I ran
update.sh
but didn't commit the change inJANUS_VERSION
. Feel free to run it and add another commit as required.