Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added graph versions 0.2.1 and 0.2.2 to compatible-versions #1288

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

chupman
Copy link
Member

@chupman chupman commented Oct 8, 2018

Signed-off-by: Chris Hupman chupman@us.ibm.com

I added 0.2.2 in addition to 0.2.1 so that if people create a 0.2.2 graph and then test it with a future snapshot build they won't hit the error. mentioned in #1285

Thank you for contributing to JanusGraph!

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

For all changes:

  • Is there an issue associated with this PR? Is it referenced in the commit message?
  • Does your PR body contain #xyz where xyz is the issue number you are trying to resolve?
  • Has your PR been rebased against the latest commit within the target branch (typically master)?
  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you written and/or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE.txt file, including the main LICENSE.txt file in the root of this repository?
  • If applicable, have you updated the NOTICE.txt file, including the main NOTICE.txt file found in the root of this repository?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?
  • If this PR is a documentation-only change, have you added a [skip ci]
    tag to the first line of your commit message to avoid spending CPU cycles in
    Travis CI when no code, tests, or build configuration are modified?

Note:

Please ensure that once the PR is submitted, you check Travis CI for build issues and submit an update to your PR as soon as possible.

Signed-off-by: Chris Hupman <chupman@us.ibm.com>
@janusgraph-bot janusgraph-bot added the cla: yes This PR is compliant with the CLA label Oct 8, 2018
Copy link
Member

@jerryjch jerryjch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.2.2 does not need to be there. But no harm either.
LGTM

@chupman
Copy link
Member Author

chupman commented Oct 8, 2018

What I remember from old issues around this error was that if someone wanted to test a snapshot with their graph they had to manually hack the pom before they built the snapshot.

So if we don't add it into the 0.2.2 release I would still recommend adding with the commit that changes the version to 0.2.3-snapshot.

@jerryjch jerryjch merged commit 181d12c into JanusGraph:0.2 Oct 9, 2018
bwatson-rti-org pushed a commit to bwatson-rti-org/janusgraph that referenced this pull request Mar 9, 2019
Added graph versions 0.2.1 and 0.2.2 to compatible-versions JanusGraph#1285
@chupman chupman added this to the Release v0.2.3 milestone Apr 23, 2019
micpod pushed a commit to micpod/janusgraph that referenced this pull request Nov 5, 2019
Added graph versions 0.2.1 and 0.2.2 to compatible-versions JanusGraph#1285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This PR is compliant with the CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants