-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle interruption for BerkeleyJE backend #3990
Conversation
de6260c
to
8e25fe9
Compare
Fixes JanusGraph#2120 Signed-off-by: Pavel Ershov <owner.mad.epa@gmail.com>
8e25fe9
to
088e37d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified that the added test BerkeleyInterruptionTest
passes (when enabled).
The refactoring changes looks good to me, but I didn't dive into the logic itself because I'm not using BerkeleyJE.
LGTM. Thank you @mad !
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
@mad @li-boxuan apparently TP tests for BerkeleyJE were not executed in this PR, but they are failing now. @li-boxuan after merging this PR (commit cdea0d7 ) the |
Revert PR: #4037 |
@mad I reverted this PR due to its failure for |
Would be great to have this fix available soon. Got a fright having the server crashed today 😅 |
Fixes #2120
Thank you for contributing to JanusGraph!
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:
master
)?For code changes:
For documentation related changes: