Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.6] Merge pull request #3972 from mad/fix-ordered-iterator #3992

Merged
merged 1 commit into from
Oct 1, 2023

Conversation

FlorianHockmann
Copy link
Member

Backport

This will backport the following commits from master to v0.6:

Questions ?

Please refer to the Backport tool documentation

Signed-off-by: Pavel Ershov <owner.mad.epa@gmail.com>
(cherry picked from commit e1ebeb7)

# Conflicts:
#	janusgraph-core/src/main/java/org/janusgraph/graphdb/util/MultiDistinctOrderedIterator.java
@FlorianHockmann FlorianHockmann enabled auto-merge (rebase) September 18, 2023 14:07
@FlorianHockmann FlorianHockmann mentioned this pull request Sep 18, 2023
9 tasks
@FlorianHockmann FlorianHockmann added this to the Release v0.6.4 milestone Sep 18, 2023
@FlorianHockmann FlorianHockmann requested a review from mad September 18, 2023 14:09
@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Sep 22, 2023
Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting bug - It's hard to spot that the custom comparator we use for the TreeMap causes data loss. Elegant fix, LGTM 👍

@li-boxuan li-boxuan merged commit d9cb889 into JanusGraph:v0.6 Oct 1, 2023
@FlorianHockmann FlorianHockmann deleted the backport/v0.6/pr-3972 branch October 4, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/skip cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants