Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.0] Make trivy scan tentative to overcome rate limits #4718

Merged
merged 1 commit into from
Nov 5, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions .github/workflows/ci-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,23 @@ jobs:
export JG_VER="$(mvn help:evaluate -Dexpression=project.version -q -DforceStdout)-$(git rev-parse --short HEAD)"
echo "JG_VER=${JG_VER}" >> $GITHUB_ENV
- name: Run Trivy vulnerability scanner
id: trivy_scan_step
if: github.repository == 'janusgraph/janusgraph'
uses: aquasecurity/trivy-action@0.24.0
# TODO: currently this step is tentative because of the rate-limiting issue.
# Thus, we add `continue-on-error: true` here, but we should remove it
# when either the issue is fixed (see: https://github.com/aquasecurity/trivy-action/issues/389)
# or we self-host trivy database.
uses: aquasecurity/trivy-action@0.28.0
continue-on-error: true
with:
image-ref: 'ghcr.io/janusgraph/janusgraph:${{ env.JG_VER }}${{ matrix.tag_suffix }}'
format: 'sarif'
output: 'trivy-results.sarif'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ACTIONS_RUNTIME_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Upload Trivy scan results to GitHub Security tab
if: github.repository == 'janusgraph/janusgraph'
if: github.repository == 'janusgraph/janusgraph' && success() && steps.trivy_scan_step.outcome == 'success'
uses: github/codeql-action/upload-sarif@v3
with:
sarif_file: 'trivy-results.sarif'
Expand Down
Loading