remove dependency on uvloop #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if needed we should be using hypercorn[uvloop] at this point. uvicorn is not used afaik so not sure it should be a dev dependency. (I’m actually not even sure if our current configuration uses uvloop at all?) uvloop seems to have some issues of its own (not present in asyncio) and the performance claim might not be real at this point in time: MagicStack/uvloop#566
odrling
force-pushed
the
remove-uvloop
branch
from
ed69f38 to
ceba76f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if needed we should be using hypercorn[uvloop] at this point. uvicorn is not used afaik so not sure it should be a dev dependency.
(I’m actually not even sure if our current configuration uses uvloop at all?)
uvloop seems to have some issues of its own (not present in asyncio) and the performance claim might not be real at this point in time: MagicStack/uvloop#566