Codefactor fixes #1 #60

JarvisCraft · 2020-02-01T19:26:08Z

This fixes issues reported by Codefactor and related ones.

… `StaticTextModelTest`

… arguments)

pull-assistant · 2020-02-01T19:26:11Z

Best reviewed: commit by commit

Optimal code review plan

Powered by Pull Assistant. Last update 43c123e ... faa2149. Read the comment docs.

JarvisCraft added 9 commits February 1, 2020 20:52

Fix wrong arguments in SimplePlaceholdersTest

43c123e

Use Arguments#arguments(..) instead of Arguments#arguments(..)

3bc1594

Use Arguments#arguments(..) instead of Arguments#arguments(..) in…

9b9741e

… `StaticTextModelTest`

Add DebuggingTextModelFactory

c1fa914

Use static constructor for DebuggingTextModelFactory

a44a4b5

Use shorter static constructor name for DebuggingTextModelFactory

8998c05

Refactor annotations for some StringFormatter's a vit

29fd239

Fix some issues in SimplePlaceholders (found by fixing related test…

b8cebb8

… arguments)

Make CLASS_NAMING_STRATEGY fields protected where needed (Fixes #38)

faa2149

JarvisCraft added bug Something isn't working enhancement New feature or request labels Feb 1, 2020

JarvisCraft requested a review from BDimasik February 1, 2020 19:26

JarvisCraft self-assigned this Feb 1, 2020

JarvisCraft marked this pull request as ready for review February 1, 2020 19:42

BDimasik approved these changes Feb 1, 2020

View reviewed changes

JarvisCraft merged commit bbc4d1c into development Feb 1, 2020

JarvisCraft deleted the codefactor-fixes branch February 1, 2020 19:59

JarvisCraft added this to the 1.0.0 milestone Nov 26, 2020

Provide feedback