Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement DelegateFactory API #98

Merged
merged 14 commits into from
Aug 9, 2020
Merged

Implement DelegateFactory API #98

merged 14 commits into from
Aug 9, 2020

Conversation

JarvisCraft
Copy link
Owner

No description provided.

@JarvisCraft JarvisCraft added the enhancement New feature or request label Aug 9, 2020
@JarvisCraft JarvisCraft self-assigned this Aug 9, 2020
@pull-assistant
Copy link

pull-assistant bot commented Aug 9, 2020 •
edited
Loading

Score: 0.92

Best reviewed: commit by commit

Optimal code review plan (1 warning)

     Add methods for getting internal class names to AsmUtil

     Remove extra i in javadoc of AsmTextModelFactory

     Fix visitIntInsn with visitVarInsn in AsmUtil

Add type-specific opcode-getters to `AsmUtil`

...mons/bytecode/asm/AsmUtil.java 48% changes removed in Cleanup AsmUtil for ...

     Fix returned opcode for integer in AsmUtil

     Fix AsmUtil's opcode getters

     Cleanup AsmTextModelFactory

     Add DelegateFactory API and its ASM implementation

     Set generated constructor's accessibility flag in AsmDelegateFactory...

     Cleanup AsmUtil for opcode-specific methods

     Add more nullability methods to ObjectUtil

     fix exceeded line-length limit in FullAccessLookupFactories

     Remove Lookup-based GcClassDefiner

     Use parent class-loader for creation of GcClassDefiners

Powered by Pull Assistant. Last update c690820 ... 6a21795. Read the comment docs.

@JarvisCraft JarvisCraft merged commit 3a5805c into development Aug 9, 2020
@JarvisCraft JarvisCraft deleted the delegate-wrapper branch August 9, 2020 16:49
@JarvisCraft JarvisCraft added this to the 1.0.0 milestone Nov 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JarvisCraft JarvisCraft

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@JarvisCraft