-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added search_existing param. #111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine with me 👍 This Action is getting a little more complex than initially intended though 😆 Thanks for adding tests and README docs 🙏
I left a note about simplifying the number of API calls we're making, to just use one query for both open and closed issues. Let me know if that makes sense.
The `search_existing` param lets you specify whether to search open and/or closed existing issues for duplicates (default is `open`).
8bd256d
to
bee3c89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I made a couple minor adjustments to docs/tests after updating from main
. Thanks for doing this 🙌
Published in https://github.com/JasonEtco/create-an-issue/releases/tag/v2.6.0! Thanks again for the contribution 🙌 |
The
search_existing
param lets you specify whether to search open and/or closed existing issues for duplicates (default isopen
).Closes #109