Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added search_existing param. #111

Merged
merged 6 commits into from
Sep 28, 2021
Merged

Conversation

dblock
Copy link
Contributor

@dblock dblock commented Sep 21, 2021

The search_existing param lets you specify whether to search open and/or closed existing issues for duplicates (default is open).

Closes #109

Copy link
Owner

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine with me 👍 This Action is getting a little more complex than initially intended though 😆 Thanks for adding tests and README docs 🙏

I left a note about simplifying the number of API calls we're making, to just use one query for both open and closed issues. Let me know if that makes sense.

src/action.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
The `search_existing` param lets you specify whether to search open and/or closed existing issues for duplicates (default is `open`).
Copy link
Owner

@JasonEtco JasonEtco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I made a couple minor adjustments to docs/tests after updating from main. Thanks for doing this 🙌

@JasonEtco JasonEtco merged commit 1e68dcc into JasonEtco:main Sep 28, 2021
@JasonEtco
Copy link
Owner

Published in https://github.com/JasonEtco/create-an-issue/releases/tag/v2.6.0! Thanks again for the contribution 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Also search closed issues
2 participants