Escape reserved keywords when inlining deps #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
force-pushed
the
handle-prop
branch
3 times, most recently
from
de0e945
to
02e12d5
Compare
Fixes #129 The code for finding the list of reserved names is kind-of hacky (see https://coq.zulipchat.com/#narrow/stream/237656-Coq-devs-.26-plugin-devs/topic/Printing.20keywords/near/292550511), and this doesn't handle all cases (in particular, there still seems to be no way to handle qualified references to `Equations.Prop.Equations.foo` which don't show up in the .glob file, or which show up in the glob file in a way that is too fragile to do mangling on), but this handles the common case of just doing `Require Import Equations.Prop.Equations.`.
JasonGross
force-pushed
the
handle-prop
branch
from
02e12d5
to
14dbb2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129
The code for finding the list of reserved names is kind-of hacky (see
https://coq.zulipchat.com/#narrow/stream/237656-Coq-devs-.26-plugin-devs/topic/Printing.20keywords/near/292550511),
and this doesn't handle all cases (in particular, there still seems to
be no way to handle qualified references to
Equations.Prop.Equations.foowhich don't show up in the .glob file, orwhich show up in the glob file in a way that is too fragile to do
mangling on), but this handles the common case of just doing
Require Import Equations.Prop.Equations..