Dynamic title for expander/collapser button (jupyterlab#15826)

* Dynamic title for expander/collapser button * Lint fixes
JasonWeill · Feb 22, 2024 · 2d68127 · 2d68127
1 parent 15875f4
commit 2d68127
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 7 deletions.
diff --git a/galata/test/jupyterlab/notebook-replace.test.ts b/galata/test/jupyterlab/notebook-replace.test.ts
@@ -30,7 +30,7 @@ test.describe('Notebook Search and Replace', () => {
 
     await page.waitForSelector('text=1/21');
 
-    await page.click('button[title="Toggle Replace"]');
+    await page.click('button[title="Show Replace"]');
 
     await page.fill('[placeholder="Replace"]', 'egg');
 
@@ -50,7 +50,7 @@ test.describe('Notebook Search and Replace', () => {
     await page.fill('[placeholder="Find"]', 'text/(\\w+)');
     await page.waitForSelector('text=1/3');
 
-    await page.click('button[title="Toggle Replace"]');
+    await page.click('button[title="Show Replace"]');
     await page.fill('[placeholder="Replace"]', 'script/$1');
     const cell = await page.notebook.getCell(2);
     await expect(page.locator('body')).not.toContainText('script/plain');
@@ -75,7 +75,7 @@ test.describe('Notebook Search and Replace', () => {
       clickCount: 4
     });
 
-    await page.click('button[title="Toggle Replace"]');
+    await page.click('button[title="Show Replace"]');
 
     await page.fill('[placeholder="Replace"]', 'egg');
 
@@ -98,7 +98,7 @@ test.describe('Notebook Search and Replace', () => {
 
     await page.waitForSelector('text=1/21');
 
-    await page.click('button[title="Toggle Replace"]');
+    await page.click('button[title="Show Replace"]');
 
     await page.fill('[placeholder="Replace"]', 'egg');
 
@@ -120,7 +120,7 @@ test.describe('Notebook Search and Replace', () => {
     await page.keyboard.press('Control+f');
     await page.fill('[placeholder="Find"]', 'test');
 
-    await page.click('button[title="Toggle Replace"]');
+    await page.click('button[title="Show Replace"]');
     await page.fill('[placeholder="Replace"]', 'egg');
 
     // TODO: Next Match press count should be one less

diff --git a/galata/test/jupyterlab/notebook-search.test.ts b/galata/test/jupyterlab/notebook-search.test.ts
@@ -94,7 +94,7 @@ test.describe('Notebook Search', () => {
     await page.waitForSelector('text=1/1');
 
     // Show replace buttons to check for visual regressions
-    await page.click('button[title="Toggle Replace"]');
+    await page.click('button[title="Show Replace"]');
     await page.fill('[placeholder="Replace"]', 'line1\nline2');
 
     const overlay = page.locator('.jp-DocumentSearch-overlay');

diff --git a/packages/documentsearch/src/searchview.tsx b/packages/documentsearch/src/searchview.tsx
@@ -682,7 +682,11 @@ class SearchOverlay extends React.Component<ISearchOverlayProps> {
               className={TOGGLE_WRAPPER}
               onClick={() => this._onReplaceToggled()}
               tabIndex={0}
-              title={trans.__('Toggle Replace')}
+              title={
+                showReplace
+                  ? trans.__('Hide Replace')
+                  : trans.__('Show Replace')
+              }
             >
               <icon.react
                 className={`${REPLACE_TOGGLE_CLASS} ${BUTTON_CONTENT_CLASS}`}