Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrades stylelint to 16 #82

Closed

Conversation

JasonWeill
Copy link
Owner

Upgrades stylelint to version 16. Removes stylelint-config-prettier because, according to its README:

As of Stylelint v15 all style-related rules have been deprecated. If you are using v15 or higher and are not making use of these deprecated rules, this plugin is no longer necessary.

Amends jupyterlab#15948 per @krassowski.

@krassowski
Copy link

It looks like only some of the CI jobs were run? I do not see the lint job here. Maybe it is worth extracting to a separate PR and opening against the jupyterlab's main branch? If it passes we can merge it quickly.

@JasonWeill
Copy link
Owner Author

After extracting the package.json changes to a separate branch, independent of short-relative-date, and after rerunning jlpm install, I see an error in stylelint-csstree-validator:

$ npm run stylelint

> @jupyterlab/repo-top@0.0.1 stylelint
> jlpm stylelint:check --fix

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/jweill/git/jupyterlab/node_modules/stylelint/lib/utils/isStandardSyntaxAtRule.js' imported from /Users/jweill/git/jupyterlab/node_modules/stylelint-csstree-validator/lib/index.js
    at new NodeError (node:internal/errors:406:5)
    at finalizeResolution (node:internal/modules/esm/resolve:233:11)
    at moduleResolve (node:internal/modules/esm/resolve:845:10)
    at defaultResolve (node:internal/modules/esm/resolve:1043:11)
    at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:383:12)
    at ModuleLoader.resolve (node:internal/modules/esm/loader:352:25)
    at ModuleLoader.getModuleJob (node:internal/modules/esm/loader:228:38)
    at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:85:39)
    at link (node:internal/modules/esm/module_job:84:36)

Notably, this package does not support Stylelint 16 (csstree/stylelint-validator#58) although there is a pull request to add support for it (csstree/stylelint-validator#59). I can open an issue about this.

@JasonWeill
Copy link
Owner Author

Closing this in favor of jupyterlab#16062, which is blocked.

@JasonWeill JasonWeill closed this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants