Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpyro #122

Merged
merged 16 commits into from
Oct 16, 2022
Merged

Numpyro #122

merged 16 commits into from
Oct 16, 2022

Conversation

thomaspinder
Copy link
Collaborator

This PR ports the existing Distrax functionality into NumPyro according to #121

Pull request type

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • [ x ] Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Issue Number: #121

@thomaspinder thomaspinder added the enhancement New feature or request label Oct 12, 2022
@thomaspinder thomaspinder added this to the v0.5.0 milestone Oct 12, 2022
@thomaspinder thomaspinder changed the base branch from master to v0.5_update October 12, 2022 20:46
@thomaspinder thomaspinder marked this pull request as ready for review October 15, 2022 20:12
@codecov
Copy link

codecov bot commented Oct 15, 2022

Codecov Report

❗ No coverage uploaded for pull request base (v0.5_update@bb26a8e). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             v0.5_update     #122   +/-   ##
==============================================
  Coverage               ?   99.23%           
==============================================
  Files                  ?       14           
  Lines                  ?     1172           
  Branches               ?        0           
==============================================
  Hits                   ?     1163           
  Misses                 ?        9           
  Partials               ?        0           
Flag Coverage Δ
unittests 99.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@daniel-dodd daniel-dodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. Main comment is about Dict vs dict consistency. Issues with docs have already been address at my end, so ignore these comments - they are mainly for myself when I come to rebase.

gpjax/gps.py Outdated
Comment on lines 198 to 199
self, train_data: Dataset, params: dict
) -> Callable[[Float[Array, "N D"]], npd.Distribution]:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dictionary typing needs to be consistent - your changes have replaced some methods with Dict to dict, while others are unchanged . I opt to us Dict as it more general, though happy to switch to dict if there's good reason - though all methods need to be changed throughout the library.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These have been reolved now.

examples/collapsed_vi.pct.py Outdated Show resolved Hide resolved
examples/collapsed_vi.pct.py Outdated Show resolved Hide resolved
examples/classification.pct.py Outdated Show resolved Hide resolved
examples/classification.pct.py Outdated Show resolved Hide resolved
@daniel-dodd daniel-dodd merged commit 4f5138b into v0.5_update Oct 16, 2022
@daniel-dodd daniel-dodd deleted the numpyro branch October 16, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants