-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Numpyro #122
Numpyro #122
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.5_update #122 +/- ##
==============================================
Coverage ? 99.23%
==============================================
Files ? 14
Lines ? 1172
Branches ? 0
==============================================
Hits ? 1163
Misses ? 9
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR. Main comment is about Dict
vs dict
consistency. Issues with docs have already been address at my end, so ignore these comments - they are mainly for myself when I come to rebase.
gpjax/gps.py
Outdated
self, train_data: Dataset, params: dict | ||
) -> Callable[[Float[Array, "N D"]], npd.Distribution]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dictionary typing needs to be consistent - your changes have replaced some methods with Dict
to dict
, while others are unchanged . I opt to us Dict
as it more general, though happy to switch to dict
if there's good reason - though all methods need to be changed throughout the library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These have been reolved now.
This PR ports the existing Distrax functionality into NumPyro according to #121
Pull request type
Issue Number: #121