Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate JaxLinOp with GPJax #154

Merged
merged 8 commits into from
Nov 29, 2022
Merged

Conversation

daniel-dodd
Copy link
Member

This PR incorporates JaxLinOp with GPJax.

(Still need to update documentation).

@thomaspinder thomaspinder marked this pull request as ready for review November 25, 2022 17:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 26, 2022

Codecov Report

Merging #154 (b41f7e4) into master (bf10dfd) will decrease coverage by 0.79%.
The diff coverage is 89.72%.

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   98.32%   97.53%   -0.80%     
==========================================
  Files          15       15              
  Lines        1377     1339      -38     
==========================================
- Hits         1354     1306      -48     
- Misses         23       33      +10     
Flag Coverage Δ
unittests 97.53% <89.72%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gpjax/kernels.py 93.22% <57.14%> (-1.86%) ⬇️
gpjax/gaussian_distribution.py 84.70% <84.70%> (ø)
gpjax/gps.py 100.00% <100.00%> (ø)
gpjax/likelihoods.py 100.00% <100.00%> (ø)
gpjax/variational_families.py 100.00% <100.00%> (ø)
gpjax/variational_inference.py 97.80% <100.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@thomaspinder thomaspinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. A few minor comments and then we can merge.

examples/uncollapsed_vi.pct.py Outdated Show resolved Hide resolved
examples/natgrads.pct.py Outdated Show resolved Hide resolved
gpjax/gaussian_distribution.py Outdated Show resolved Hide resolved
gpjax/gps.py Outdated Show resolved Hide resolved
gpjax/gps.py Show resolved Hide resolved
gpjax/variational_families.py Outdated Show resolved Hide resolved
@thomaspinder thomaspinder merged commit dbaa5ce into master Nov 29, 2022
@thomaspinder thomaspinder deleted the incorporate_jax_linear_operator branch April 7, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants