- app version = 5.6.19 (bcgov#600)

- imported updated shared correct-name and mixins
- updated some validations
- updated misc whitespace
- added additional options to ResultingBusinessName.vue
- added additional option to NameRequestInfo.vue
- fixed numbered company suffix
- added conditional links to return to proper steps
- updated save/resume name options
- updated more validations
- temporarily skipped some unit tests
- misc cleanup

Co-authored-by: Severin Beauvais <severin.beauvais@gov.bc.ca>

package.json

@@ -1,6 +1,6 @@
 {
   "name": "business-create-ui",
-  "version": "5.6.18",
+  "version": "5.6.19",
   "private": true,
   "appName": "Create UI",
   "sbcName": "SBC Common Components",
@@ -23,7 +23,7 @@
     "@bcrs-shared-components/confirm-dialog": "1.2.1",
     "@bcrs-shared-components/contact-info": "1.2.15",
     "@bcrs-shared-components/corp-type-module": "1.0.11",
-    "@bcrs-shared-components/correct-name": "1.0.33",
+    "@bcrs-shared-components/correct-name": "1.0.36",
     "@bcrs-shared-components/court-order-poa": "3.0.11",
     "@bcrs-shared-components/date-picker": "1.2.15",
     "@bcrs-shared-components/document-delivery": "1.2.0",
@@ -35,7 +35,7 @@
     "@bcrs-shared-components/interfaces": "1.1.5",
     "@bcrs-shared-components/jurisdiction": "1.0.1",
     "@bcrs-shared-components/limited-restoration-panel": "1.0.5",
-    "@bcrs-shared-components/mixins": "1.1.33",
+    "@bcrs-shared-components/mixins": "1.1.34",
     "@bcrs-shared-components/nature-of-business": "1.2.14",
     "@bcrs-shared-components/relationships-panel": "1.0.9",
     "@bcrs-shared-components/staff-comments": "1.3.15",

src/App.vue

@@ -946,6 +946,12 @@ export default class App extends Mixins(CommonMixin, DateMixin, FilingTemplateMi
         this.nameRequestInvalidErrorDialog = true
       })
 
+      //
+      // The NR checks below are sort-of a duplicate of code in BusinessName.vue and
+      // ResultingBusinessName.vue, but we assume the other checks passed if the user
+      // was able to add the NR to this filing, so these checks should be sufficient.
+      //
+
       // ensure NR was found
       if (!nrResponse) {
         this.nameRequestInvalidType = NameRequestStates.NOT_FOUND

src/components/Amalgamation/AmalgamatingBusinesses.vue

@@ -260,7 +260,7 @@ export default class AmalgamatingBusinesses extends Mixins(AmalgamationMixin, Co
   /** Called when Jurisdiction menu item is changed. */
   onJurisdictionChange (jurisdiction: any): void {
     this.jurisdiction = jurisdiction
-    this.isCan = jurisdiction.group === 0
+    this.isCan = (jurisdiction.group === 0)
     this.jurisdictionErrorMessage = this.jurisdiction ? '' : 'Home jurisdiction is required'
     this.isMrasJurisdiction = MrasJurisdictions.includes(
       this.jurisdiction.text.toLowerCase()

src/components/Amalgamation/BusinessTable.vue

@@ -99,7 +99,6 @@ export default class BusinessTable extends Mixins(AmalgamationMixin) {
   readonly AmlTypes = AmlTypes
   readonly GetCorpFullDescription = GetCorpFullDescription
 
-  @Action(useStore) setDefineCompanyStepValidity!: (x: boolean) => void
   @Action(useStore) spliceAmalgamatingBusiness!: (x: number) => void
 
   /**
@@ -173,7 +172,10 @@ export default class BusinessTable extends Mixins(AmalgamationMixin) {
   @Watch('businesses', { deep: true, immediate: true })
   @Emit('valid')
   private emitValidity (): boolean {
-    return this.businesses.every(business => business.status === AmlStatuses.OK)
+    return (
+      (this.businesses.length > 0) &&
+      this.businesses.every(business => business.status === AmlStatuses.OK)
+    )
   }
 }
 </script>

src/components/Amalgamation/ResultingBusinessName.vue

@@ -5,7 +5,7 @@
   >
     <!-- Editing Mode -->
     <div
-      v-if="!isNewName"
+      v-if="!getCorrectNameOption"
       class="section-container"
       :class="{ 'invalid-section': invalidSection }"
     >
@@ -27,6 +27,7 @@
         >
           <CorrectName
             actionTxt="choose the resulting business name"
+            :amalgamatingBusinesses="getAmalgamatingBusinesses"
             :businessId="getBusinessId"
             :companyName="companyName"
             :correctionNameChoices="correctionNameChoices"
@@ -46,7 +47,7 @@
     <!-- Display Mode -->
     <template v-else>
       <NameRequestInfo />
-      <NameTranslations class="mt-n8" />
+      <NameTranslations />
 
       <v-btn
         text
@@ -67,11 +68,11 @@
 import { Component, Mixins } from 'vue-property-decorator'
 import { Getter, Action } from 'pinia-class'
 import { useStore } from '@/store/store'
-import { NameRequestMixin } from '@/mixins'
-import { EmptyNameRequest, NameRequestIF } from '@/interfaces/'
+import { NameRequestMixin } from '@/mixins/'
+import { AmalgamatingBusinessIF, EmptyNameRequest, NameRequestIF, NameTranslationIF } from '@/interfaces/'
 import { LegalServices } from '@/services/'
 import { CorrectNameOptions, NrRequestActionCodes } from '@bcrs-shared-components/enums/'
-import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module'
+import { CorpTypeCd } from '@bcrs-shared-components/corp-type-module/'
 import { CorrectName } from '@bcrs-shared-components/correct-name/'
 import NameRequestInfo from '@/components/common/NameRequestInfo.vue'
 import NameTranslations from '@/components/common/NameTranslations.vue'
@@ -84,6 +85,7 @@ import NameTranslations from '@/components/common/NameTranslations.vue'
   }
 })
 export default class ResultingBusinessName extends Mixins(NameRequestMixin) {
+  @Getter(useStore) getAmalgamatingBusinesses!: AmalgamatingBusinessIF[]
   @Getter(useStore) getBusinessId!: string
   @Getter(useStore) getBusinessLegalName!: string
   @Getter(useStore) getCorrectNameOption!: CorrectNameOptions
@@ -96,10 +98,9 @@ export default class ResultingBusinessName extends Mixins(NameRequestMixin) {
   @Action(useStore) setCorrectNameOption!: (x: CorrectNameOptions) => void
   @Action(useStore) setNameRequest!: (x: NameRequestIF) => void
   @Action(useStore) setNameRequestApprovedName!: (x: string) => void
+  @Action(useStore) setNameTranslations!: (x: NameTranslationIF[]) => void
 
   // Local properties
-  businessNameOption = null as string
-  // businessNameOption = this.getNameRequestNumber ? 'named' : 'numbered'
   formType = null as CorrectNameOptions
 
   readonly correctionNameChoices = [
@@ -112,25 +113,23 @@ export default class ResultingBusinessName extends Mixins(NameRequestMixin) {
   get companyName (): string {
     return (this.getNameRequestApprovedName || this.getBusinessLegalName)
   }
+
   /** This section's validity state (when prompted by app). */
   get invalidSection (): boolean {
     return (this.getShowErrors && !this.getCorrectNameOption)
   }
 
-  /** Called when component is created. */
-  created (): void {
-    // this.businessNameOption = this.getNameRequestNumber ? 'named' : 'numbered'
-  }
-
   /**
    * Fetches and validation a NR.
    * @param nrNum the NR number
-   * @param businessId the business id
+   * @param businessId the business id (not used here but needed in method signature)
    * @param phone the phone number to match
    * @param email the email address to match
    * @returns a promise to return the NR, or throws a printable error
    */
-  async fetchAndValidateNr (nrNum: string, businessId: string, phone: string, email: string): Promise<NameRequestIF> {
+  async fetchAndValidateNr (
+    nrNum: string, businessId: string, phone: string, email: string
+  ): Promise<NameRequestIF> {
     const nameRequest = await LegalServices.fetchValidContactNr(nrNum, phone, email)
     if (!nameRequest) throw new Error('Error fetching Name Request')
 
@@ -149,19 +148,13 @@ export default class ResultingBusinessName extends Mixins(NameRequestMixin) {
     this.setNameRequest(nameRequest)
   }
 
-  /** Whether a new business legal name was entered. */
-  get isNewName (): boolean {
-    // Approved Name is null when we start
-    // and is set when a name option is selected
-    return !!this.getNameRequestApprovedName
-  }
-
-  /** Reset company name values to original. */
+  /** Resets company name values to original when Cancel was clicked. */
   resetName (): void {
     // clear out existing data
     this.setNameRequest(EmptyNameRequest)
     this.setNameRequestApprovedName(null)
     this.setCorrectNameOption(null)
+    this.setNameTranslations([])
 
     // reset flag
     this.formType = null

src/components/Restoration/BusinessName.vue

@@ -142,7 +142,7 @@ export default class BusinessName extends Mixins(CommonMixin, DateMixin, NameReq
     return !!this.getNameRequestApprovedName
   }
 
-  /** Reset company name values to original. */
+  /** Resets company name values to original when Cancel was clicked. */
   resetName (): void {
     // clear out existing data
     this.setNameRequest(EmptyNameRequest)

src/components/common/AddNameTranslation.vue

@@ -5,6 +5,7 @@
       <v-text-field
         id="name-translation-input"
         v-model="nameTranslation"
+        autofocus
         filled
         persistent-hint
         label="Enter Name Translation"