22681_remove_notes_ar_filer (bcgov#2965)

JazzarKarim · Sep 10, 2024 · aa8f84c · aa8f84c
1 parent 27e6227
commit aa8f84c
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/queue_services/entity-filer/src/entity_filer/filing_processors/annual_report.py b/queue_services/entity-filer/src/entity_filer/filing_processors/annual_report.py
@@ -54,7 +54,6 @@ def process(business: Business, filing: Dict, filing_meta: FilingMeta, flag_on):
         if not eligibility:
             batch_processing, _ = InvoluntaryDissolutionService.get_in_dissolution_batch_processing(business.id)
             batch_processing.status = BatchProcessing.BatchProcessingStatus.WITHDRAWN.value
-            batch_processing.notes = 'Moved back to good standing'
             batch_processing.last_modified = datetime.datetime.utcnow()
 
     # save the annual report date to the filing meta info

diff --git a/queue_services/entity-filer/tests/unit/filing_processors/test_annual_report.py b/queue_services/entity-filer/tests/unit/filing_processors/test_annual_report.py
@@ -78,20 +78,19 @@ def test_process_ar_filing_involuntary_dissolution(app, session, test_name, flag
         filing = create_filing(json_filing=ar, business_id=business.id)
         annual_report.process(business, filing.filing_json['filing'], filing_meta=filing_meta, flag_on=flag_on)
 
-    # check it out
-    if flag_on and in_dissolution and not eligibility:
-        assert batch_processing.status == BatchProcessing.BatchProcessingStatus.WITHDRAWN.value
-        assert batch_processing.notes == 'Moved back to good standing'
-    else:
-        if in_dissolution:
-            assert batch_processing.status == BatchProcessing.BatchProcessingStatus.PROCESSING.value
-            assert batch_processing.notes == ''
-        if legal_type == 'CP':
-            # require the agm for [Business.LegalTypes.COOP.value, Business.LegalTypes.XPRO_LIM_PARTNR.value]
-            assert str(business.last_agm_date) == str(agm_date)
-            assert str(business.last_ar_date) == str(agm_date)
+        # check it out
+        if flag_on and in_dissolution and not eligibility:
+            assert batch_processing.status == BatchProcessing.BatchProcessingStatus.WITHDRAWN.value
         else:
-            assert str(business.last_ar_date) == str(ar_date)
+            if in_dissolution:
+                assert batch_processing.status == BatchProcessing.BatchProcessingStatus.PROCESSING.value
+                assert batch_processing.notes == ''
+            if legal_type == 'CP':
+                # require the agm for [Business.LegalTypes.COOP.value, Business.LegalTypes.XPRO_LIM_PARTNR.value]
+                assert str(business.last_agm_date) == str(agm_date)
+                assert str(business.last_ar_date) == str(agm_date)
+            else:
+                assert str(business.last_ar_date) == str(ar_date)
 
 
 async def test_process_ar_filing_no_agm(app, session):