Backport a ton of changes #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatyouhide
commented
Oct 17, 2023
There was a problem hiding this comment.
Added Dialyzer and linting to CI.
Comment on lines
+1
to
+2
| erlang 26.0.2 | ||
| elixir 1.15.4-otp-26 |
There was a problem hiding this comment.
Modernized this
| defexception message: "Server Error" | ||
|
|
||
| @impl true | ||
| def exception(options) when is_list(options) do |
There was a problem hiding this comment.
The error message is significantly more helpful now
Jcambass
approved these changes
Oct 30, 2023
whatyouhide
commented
Oct 30, 2023
There was a problem hiding this comment.
@Jcambass sound good, thank you. I added a few comments to make the re-review easier. No rush on my end, I’m using this from my fork directly in Xandra, since it's a test-only dependency anyways 🙃
whatyouhide
commented
Oct 30, 2023
Jcambass
reviewed
Nov 16, 2023
|
Woooohooooo thanks @Jcambass! Let me know if you release a new version 🙃 |
|
Thank you! I'll let you know once I've written the changelog and publish a new version. |
|
Apologise for the delay. I published a new version in February but forget to comment here 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Jcambass! 👋
I’m using this library in Xandra, a Cassandra/ScyllaDB driver I maintain. I'm using a fork of this since I needed a bunch of things to be fixed, such as making sure proxies and toxics get destroyed after
apply!/2and things like that.I don't have the time right now to do all these commits as nice tidy PRs to this upstream, but I figured I'd dump it here in case you wanna merge this in. The commits are split up nicely, so you should be able to review them individually.
Cheers!