Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a new follow-route task and evaluation metrics #643

Merged
merged 13 commits into from
Oct 30, 2023

Conversation

Qi-Zha0
Copy link
Contributor

@Qi-Zha0 Qi-Zha0 commented Oct 6, 2023

No description provided.

@Qi-Zha0
Copy link
Contributor Author

Qi-Zha0 commented Oct 6, 2023

For an example, run python driver_carla.py -c configs/CARLA/default_carla_test_suite.yml -s

Copy link
Member

@sergiopaniego sergiopaniego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to provide support to previously working code. Let's make changes toward that.
Great work with this PR!

@@ -67,7 +79,7 @@ def launch_env(launch_file, random_spawn_point=False, carla_simulator=False, con
logger.info("SimulatorEnv: launching simulator server.")
time.sleep(5)
with open("/tmp/.roslaunch_stdout.log", "w") as out, open("/tmp/.roslaunch_stderr.log", "w") as err:
if random_spawn_point:
if random_spawn_point or (spawn_point is not None and town is not None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It generates an error here when running other config files:

python3 driver_carla.py -c configs/CARLA/default_carla.yml -g

@sergiopaniego sergiopaniego merged commit ff7d7ce into JdeRobot:noetic-devel Oct 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants