Merge pull request #53 from JdeRobot/issue-52

Fix pydantic missing type annotations

manager/comms/consumer_message.py

@@ -2,7 +2,7 @@
 
 import json
 from functools import singledispatchmethod
-from typing import Any
+from typing import Any, Optional
 
 from pydantic import BaseModel
 
@@ -16,7 +16,7 @@ class ManagerConsumerMessage(BaseModel):
     """
     id: str
     command: str
-    data: Any
+    data: Optional[Any] = None
 
     def response(self, response: Any = None) -> ManagerConsumerMessage:
         """

manager/manager/launcher/launcher_console.py

@@ -4,14 +4,15 @@
 import time
 import os
 import stat
+from typing import List, Any
 
 
 class LauncherConsole(ILauncher):
     display: str
-    internal_port: str
-    external_port: str
-    running = False
-    threads = []
+    internal_port: int
+    external_port: int
+    running:bool = False
+    threads: List[Any] = []
 
     def run(self, callback):
         DRI_PATH = os.path.join("/dev/dri", os.environ.get("DRI_NAME", "card0"))

manager/manager/launcher/launcher_engine.py

@@ -10,7 +10,7 @@ class LauncherEngine(BaseModel):
     exercise_id: str
     launch: dict
 
-    module = '.'.join(__name__.split('.')[:-1])
+    module:str = '.'.join(__name__.split('.')[:-1])
     terminated_callback: Any = None
 
     def run(self):

manager/manager/launcher/launcher_gazebo_view.py

@@ -4,17 +4,18 @@
 import time
 import os
 import stat
+from typing import List, Any
 
 
 class LauncherGazeboView(ILauncher):
     exercise_id: str
     display: str
-    internal_port: str
-    external_port: str
+    internal_port: int
+    external_port: int
     height: int
     width: int
-    running = False
-    threads = []
+    running: bool = False
+    threads: List[Any] = []
 
     def run(self, callback):
         DRI_PATH = os.path.join(