Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On vnc visor terminate, not process found is displayed #157

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

javizqh
Copy link
Collaborator

@javizqh javizqh commented Sep 2, 2024

The bug happens in the line changed in the code.

This is not solved

@javizqh javizqh linked an issue Sep 2, 2024 that may be closed by this pull request
Old threads are removed from thread lists, and is_alive() check is performed before terminating the thread
@espilya espilya marked this pull request as ready for review September 7, 2024 21:43
@javizqh
Copy link
Collaborator Author

javizqh commented Sep 8, 2024

For me works fine, but I prefer to have it double checked before merging.

So @dduro2020 if you can test it, and works for you we will merge it.

Copy link
Collaborator

@dduro2020 dduro2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried restarting exercises, changing them and changing worlds, the error does not appear.

@javizqh javizqh merged commit 3e76188 into humble-devel Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

On vnc visor terminate, not process found is displayed
3 participants