Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Broken Pipe #162

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Fixed Broken Pipe #162

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee29bc5
Update server.py
CDAM2020 Sep 10, 2024
2fb73fc
Added lock to avoid broken pipe. Error fixed
dduro2020 Sep 10, 2024
1917e85
Added comment
dduro2020 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions manager/libs/applications/compatibility/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,14 @@ def __init__(
self.server.set_fn_client_left(self.on_close)
self.server.set_fn_message_received(self.on_message)
self.current_client = None
self.client_lock = threading.Lock() # Used to avoid concurrency problems
self._stop = threading.Event()
LogManager.logger.info("Server Launched")

def run(self) -> None:
try:
self.server.run_forever()
if self._stop.isSet():
return
while not self._stop.is_set():
self.server.run_forever()
except Exception as ex:
LogManager.logger.exception(ex)

Expand All @@ -35,19 +35,23 @@ def stop(self) -> None:
self.server.shutdown_gracefully()

def send(self, data):
if self.current_client is not None:
self.server.send_message(self.current_client, data)
else:
LogManager.logger.error("No client is connected.")
with self.client_lock:
if self.current_client is not None:
self.server.send_message(self.current_client, data)

def on_message(self, client, server, message):
payload = json.loads(message)
self.update_callback(payload)
LogManager.logger.debug(f"Message received from template: {message[:30]}")


def on_close(self, client, server):
LogManager.logger.info("Connection with client closed")
with self.client_lock:
if client == self.current_client:
self.current_client = None

def on_open(self, client, server):
LogManager.logger.info(f"New client connected {client}")
self.current_client = client
with self.client_lock:
self.current_client = client