Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only difference between the two launchers is the command for noVNC
noetic uses noVNC version 1.2.0 which has a script called launch.sh
humble uses the latest noVNC in which it uses novnc_proxy
novnc_proxy is not there in noVNC version 1.2.
The possible solutions were:
OR
OR
Option 2 will require changes in the original manager.py used by noetic RADI, which could lead to unexpected breaks, hence avoiding it.
MUST be merged with JdeRobot/RoboticsAcademy#2144