Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unifying launchers #41

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Conversation

pawanw17
Copy link
Collaborator

@pawanw17 pawanw17 commented Jun 24, 2023

The only difference between the two launchers is the command for noVNC

noetic uses noVNC version 1.2.0 which has a script called launch.sh
humble uses the latest noVNC in which it uses novnc_proxy

novnc_proxy is not there in noVNC version 1.2.
The possible solutions were:

  1. Making conditions in the launchers and using launch.sh or novnc_proxy based on the ros version. (working)
    OR
  2. Upgrade the noVNC version in noetic and use ROS2 launchers only (working)
    OR
  3. Deprecate the noVNC version in humble to 1.2.0 (not working)

Option 2 will require changes in the original manager.py used by noetic RADI, which could lead to unexpected breaks, hence avoiding it.

MUST be merged with JdeRobot/RoboticsAcademy#2144

@jmplaza
Copy link
Member

jmplaza commented Jun 24, 2023

Hi @pawanw17 , recently @ReyDoran introduced the ROS-release autodetection feature in the RAM. Maybe we should go with Option1. That feature was intentionally introduced to deal with the subtle differences in ROS1 launching and ROS2 launching

@pawanw17
Copy link
Collaborator Author

pawanw17 commented Jun 24, 2023

yes @jmplaza, I have used parts of @ReyDoran 's autodetection

Here:

@pawanw17 pawanw17 changed the title [Work in Progress] Unifying launchers Unifying launchers Jun 26, 2023
@ReyDoran ReyDoran linked an issue Jul 4, 2023 that may be closed by this pull request
@ReyDoran ReyDoran merged commit 6c815f6 into JdeRobot:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify ROS independant RAM launchers
3 participants