Locks and Multi fan-in and fan-out #195
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Locks: When multiple writers are writing to same wire, its necessary to lock the shared memory while write is in progress.
Enable in FSM: In the case of FSMs, a block should be able to disable itself after it transitions to the next state. But the Enable wire of a block is an input block and not writeable by it. This PR changes this by giving a separate interface for enable wire as a property of the inputs block. And also allows the block to disable by setting
inputs.enable = False
to disable itself safely.Multi Fan-in and Fan-out: When we have the scenario of multiple wires going to same input or same output having multiple wires to different inputs, we have to use the same underlying shared memory so that data can be modified correctly.