Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.9.1 react15 #1482

Closed
wants to merge 4 commits into from
Closed

Conversation

vasyl-purchel
Copy link

Updating peer dependency to React 15.3.1 in order to make it possible to use this component in application built with React 15 without throwing errors on unmet peer dependencies.

Change-Id: Ife88a16e46821e8a94c190458098a795209fc8b4
Change-Id: Ib230e3644995636d2f45a790aee3f16fde4c6c95
Change-Id: I01cf6e0a453f92e261283812afdb23fe7310baec
Change-Id: Icba4b2b31ff35b1e24ceccb9cc7812320e6d306a
@bassjacob
Copy link
Collaborator

Is the component still compatible with 0.14? Should we make the peerdep at least greater than 14 rather than specifically 15?

@JedWatson
Copy link
Owner

We're well past the last release of v0.9 in master, and about to cut a final 1.0.0 release so I don't see how we can easily release a patch that adds v15 peer deps to 0.9, not to mention I haven't tested 0.9 on React 15 and can't confirm it is compatible.

v0.6.x is the last release compatible with React 0.13, up to 0.9 was developed and tested with 0.14, 1.0.0 (which was a comprehensive rewrite) is compatible with 0.14 and 15 and tested extensively with 15.

@JedWatson
Copy link
Owner

Going to close this as unmergeable unless someone wants to perform some git magic to create a new branch from the last 0.9.x release and submit this PR against that, sorry @vasyl-purchel

If you really need this release on npm I'd suggest publishing it as your own scoped package from your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants